Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label tag #24482

Merged
merged 4 commits into from
May 7, 2019
Merged

Add label tag #24482

merged 4 commits into from
May 7, 2019

Conversation

hardik-codes
Copy link
Contributor

Pull Request for Issue #24467

Summary of Changes

Add label tag to search field

Testing Instructions

Code Inspection

Documentation Changes Required

None

@hardik-codes
Copy link
Contributor Author

@zwiastunsw please test

@ghost ghost added J3 Issue and removed J3 Issue labels Apr 5, 2019
@fugi98
Copy link

fugi98 commented Apr 7, 2019

Where can i see the code and try to do the changes in it?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24482.

@ghost
Copy link

ghost commented Apr 7, 2019

Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
@Quy
Copy link
Contributor

Quy commented Apr 14, 2019

I have tested this item ✅ successfully on f44b2b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24482.

@ghost ghost added the a11y Accessibility label Apr 14, 2019
@hardik-codes
Copy link
Contributor Author

one more tester please

@brianteeman
Copy link
Contributor

@hardik-codes please dont keep requesting tests. When people have the time they will test.

@HLeithner
Copy link
Member

@hardik-codes you can join the joomla bug squad and talk to people or ask students of the gsoc project to test PRs in the gsoc glip chat. Ping me on glip.

@hardik-codes
Copy link
Contributor Author

@hardik-codes please dont keep requesting tests. When people have the time they will test.

I'm really sorry about that. Will keep this in mind from next time onwards

@hardik-codes
Copy link
Contributor Author

@hardik-codes you can join the joomla bug squad and talk to people or ask students of the gsoc project to test PRs in the gsoc glip chat. Ping me on glip.

sure

@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on f44b2b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24482.

@ghost ghost removed the a11y Accessibility label Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 15, 2019
@ghost ghost added the a11y Accessibility label Apr 18, 2019
@ghost ghost changed the title [staging] [a11y] Add label tag Add label tag Apr 18, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@SniperSister SniperSister merged commit 1dfc4d8 into joomla:staging May 7, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 7, 2019
@SniperSister
Copy link
Contributor

Merged! Thanks a lot :)

@SniperSister SniperSister added this to the Joomla 3.9.7 milestone May 7, 2019
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
* Added label tag to com_search search field

Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants