Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor text for the link #24776

Closed
wants to merge 3 commits into from
Closed

Anchor text for the link #24776

wants to merge 3 commits into from

Conversation

jeckodevelopment
Copy link
Member

Pull Request for Issue #24739

Summary of Changes

The URL field description is used as anchor text for the URL.
This PR is based on the work and the suggestion of Laura ( @rytechsites ): #24739 (comment)

PROs: links will have now an anchor text.
Cons: All the URLs will have the same anchor text.

Testing Instructions

Create a field, choose type "URL", specify a Description for the URL field.
Create an article, fill the URL field.

Expected result

In the frontend you won't see anymore the raw URL, but you will see the description of the field as anchor text for all the URLs using such field.

Documentation Changes Required

Add this behavior to the URL field documentation page: https://docs.joomla.org/J3.x:Adding_custom_fields/Url_Field

@SharkyKZ
Copy link
Contributor

SharkyKZ commented May 3, 2019

Using field description here is totally wrong. It is shown in edit form.

Description
A description of the field that will be displayed in the label tooltip.

@infograf768
Copy link
Member

I am not in favor of this patch.
Not only we would have the same anchor text but it would be the same whatever the language as the description (which would have to be an ini string constant) is not going through JText.

@infograf768
Copy link
Member

Closing. See discussion #24739

@infograf768 infograf768 closed this May 4, 2019
@jeckodevelopment jeckodevelopment deleted the anchotext_URLfield branch May 5, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants