[4.0] Add prepared statements for mod tags popular

[HLeithner]

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries.

Testing Instructions

Use the module in all ways you can think of.

• create a frontend module
• create articles with tags
• check the tags in the module if its the same without the PR

Expected result

Nothing changed.

[Quy]

Apply $db->quoteName?

[alikon]

I have tested this item ✅ successfully on 86ee169

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25043.}

[Quy]

Error: Unknown column 'MAX(tag_id) AS tag_id' in 'field list': Unknown column 'MAX(tag_id) AS tag_id' in 'field list'

[Quy]

Warning: Illegal offset type in \libraries\vendor\joomla\database\src\Mysqli\MysqliQuery.php on line 123

Warning: mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 425

[alikon]

could be related to this line https://github.com/joomla/joomla-cms/pull/25043/files#diff-b76ce82322bfdac12f53dcffdcc8a16cR104 the actual bind() doesn't allow what has been made here
probably a composer update will solve

[HLeithner]

I closed my own PR joomla-framework/database#162 accidentally, this one is needed for this PR to work.

Applying the database Pr makes this one work again...

[alikon]

When I've tested this one I should have the framework patched Il ven 21 giu 2019, 10:50 Harald Leithner <notifications@github.com> ha scritto:

…

I closed my own PR joomla-framework/database#162 <joomla-framework/database#162> accidentally, this one is needed for this PR to work. Applying the database Pr makes this one work again... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25043?email_source=notifications&email_token=AABMLMJQGMYM5QUV5BIH7QTP3SI53A5CNFSM4HQTTAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYH3YII#issuecomment-504347681>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABMLMJDD4V5BNQCLFOCXQTP3SI53ANCNFSM4HQTTAEQ> .

[SharkyKZ]

I have tested this item ✅ successfully on 19d980f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25043.}

[ghost]

@alikon can you please retest?

[Quy]

I have tested this item ✅ successfully on 19d980f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25043.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25043.}

[wilsonge]

Thanks!