Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing lang strings for Article XTD in frontend #25436

Closed

Conversation

infograf768
Copy link
Member

Pull Request for Issue #25344

Summary of Changes

Adding missing strings for article alias

Before patch

Screen Shot 2019-07-05 at 07 44 32

After patch

Screen Shot 2019-07-05 at 08 16 08

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 5, 2019
@infograf768
Copy link
Member Author

infograf768 commented Jul 5, 2019

Note: Imho we should solve in another way the apparently missing Sorting strings when debug lang on for Contact, Article and Field as these are no use in the modals.

@infograf768
Copy link
Member Author

@HLeitner
We should consider this for 3.9.9 imho. We will manage with TTs.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jul 5, 2019

Just realized the sorting is used. We just can't see it in the modal because it has hidden-phone class applied. I'm certain this is not intentional.

@infograf768
Copy link
Member Author

Not sure it is related to hidden-phone

@brianteeman
Copy link
Contributor

It is the hidden-phone hidden-tablet in the layout - so if you override the layout or use a template that doesnt have those classes it will display with the missing strings of course

This is why I wrote #25344 (comment)

image

@infograf768 infograf768 closed this Jul 5, 2019
@infograf768
Copy link
Member Author

As you know better, of course, please make patch.
(I did not find what has to be modified to display the sort fields)

@infograf768 infograf768 deleted the langstring_article_xtd branch July 5, 2019 06:51
@brianteeman
Copy link
Contributor

Stop with the personal comments - its really pathetic

<div class="js-stools-container-list hidden-phone hidden-tablet">
<?php echo $this->sublayout('list', $data); ?>
</div>

@ghost
Copy link

ghost commented Jul 5, 2019

please all focus on Issue, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants