[#32768] Fix wrong param to helper route #2566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem right. Because in the content helper router we're looking for an integer https://github.com/joomla/joomla-cms/blob/master/components/com_content/helpers/route.php#L39 |
|
Yes @wilsonge , you are correct! I closing this issue. Thanks. |
|
I find 9 occurences of ContentHelperRoute::getArticleRoute($item->slug, $item->catslug) in core. |
|
FYI: The Joomla core routers don't require the catslug. Its a leftover from Joomla 1.5 and hasn't been necessary since Joomla 1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracker: #32768
joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32768&start=0