-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] left sidebar align #26210
[4.0] left sidebar align #26210
Conversation
This PR needs to include no top margin for the container-component as well. As I said in my issue #26201, if there is no left sidebar but there is a right sidebar, then the margin is applied to the component area and the right sidebar appears higher than the component (at least it does on larger screens; on the smallest screens both left and right sidebars drop down below the component area.) |
@Scrabble96 You are right. I added the missing class now. |
@astridx As I don't know about npm /node, I tried as follows: But I think there is missing after: margin-bottom:20px; } Because the: + div becomes:red instead green. So, I added the missing } This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210. |
@ChristineWk Thank you for trying to test. If you like to make you familiar with the environment this is a good entry for windows users: https://www.wicked-software.de/joomla-v4-0-win10-composer-and-npm |
@astridx Thank you for your info - I hv to study :-) just OT: On my test-site (using user.css) entered: .site-grid .container-header + div:not(.container-banner) { |
Hi Astrid, Thanks for adding commits. After activating under Options CI Server Settings > Switch CI Integration > ON unfortenately (still): rgds Christine This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210. |
The reason for might be: |
No that would not be the issue |
Thank you for info. What is the issue for? Maybe: "Some checks were not successful. Build is failing ...." This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210. |
I have tested this item 🔴 unsuccessfully on 068cc4a When a module is present at sidebar-left position, the margin-top: 15px applies to it. And, when there is no sidebar-left position, the margin-top: 15px applies to the component area, This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210. |
I have tested this item ✅ successfully on 068cc4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210. |
I have tested this item ✅ successfully on 068cc4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210. |
Thanks! |
Thank you :-) |
Pull Request for Issue #26201.
Summary of Changes
No margin for sidebar left.
Testing Instructions
node build.js --compile-css
for updating the changedscss
file. Alternatively you can runnpm i
.Expected result
Cassiopeia sidebars and component area horizontally aligned.
Actual result
Cassiopeia sidebars and component area not horizontally aligned.
Documentation Changes Required
No