Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] left sidebar align #26210

Merged
merged 7 commits into from
Oct 19, 2019
Merged

[4.0] left sidebar align #26210

merged 7 commits into from
Oct 19, 2019

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Sep 8, 2019

Pull Request for Issue #26201.

Summary of Changes

No margin for sidebar left.

Testing Instructions

  1. Apply this patch and run node build.js --compile-css for updating the changed scss file. Alternatively you can run npm i.
  2. Add a module to the left sidebar.
  3. Open the side in the front end and see, that the Cassiopeia sidebars and component area horizontally aligned.

Expected result

Cassiopeia sidebars and component area horizontally aligned.

Actual result

Cassiopeia sidebars and component area not horizontally aligned.

Documentation Changes Required

No

@Scrabble96
Copy link
Contributor

This PR needs to include no top margin for the container-component as well. As I said in my issue #26201, if there is no left sidebar but there is a right sidebar, then the margin is applied to the component area and the right sidebar appears higher than the component (at least it does on larger screens; on the smallest screens both left and right sidebars drop down below the component area.)

@astridx
Copy link
Contributor Author

astridx commented Sep 8, 2019

@Scrabble96 You are right. I added the missing class now.

@ChristineWk
Copy link

@astridx As I don't know about npm /node, I tried as follows:
Changed in template.css (line 12349) from the file: a236fc6 accordingly.

But I think there is missing after: margin-bottom:20px; } Because the: + div becomes:red instead green. So, I added the missing }
Unfortunately still Actual Result. Also I don't know how to compile it to scss file. Sorry.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.

@ghost ghost changed the title left sidebar align [4.0] left sidebar align Sep 9, 2019
@astridx
Copy link
Contributor Author

astridx commented Sep 9, 2019

@ChristineWk Thank you for trying to test. If you like to make you familiar with the environment this is a good entry for windows users: https://www.wicked-software.de/joomla-v4-0-win10-composer-and-npm

@ChristineWk
Copy link

@astridx Thank you for your info - I hv to study :-)

just OT: On my test-site (using user.css) entered:

.site-grid .container-header + div:not(.container-banner) {
margin-top: 0px;
}
it looks OK.
regards, christine

@ChristineWk
Copy link

Hi Astrid,

Thanks for adding commits. After activating under Options CI Server Settings > Switch CI Integration > ON unfortenately (still):
The patch could not be applied either due to missing connection to the server or missing patch on the server.

rgds Christine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.

@ChristineWk
Copy link

The reason for might be:
"This branch is out-of-date with the base branch ..."

@brianteeman
Copy link
Contributor

No that would not be the issue

@ChristineWk
Copy link

@brianteeman

Thank you for info. What is the issue for? Maybe: "Some checks were not successful. Build is failing ...."
If you think there is no way, then I would have to stop the activities in this regard.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.

@Kaustubharas
Copy link

I have tested this item 🔴 unsuccessfully on 068cc4a

Cassiopeia sidebars and component area not horizontally aligned.

When a module is present at sidebar-left position, the margin-top: 15px applies to it.

And, when there is no sidebar-left position, the margin-top: 15px applies to the component area,


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.

@patjun
Copy link

patjun commented Oct 19, 2019

without patch
without-patch

patch applied
patch-applied

@patjun
Copy link

patjun commented Oct 19, 2019

I have tested this item ✅ successfully on 068cc4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.

@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on 068cc4a

After test sidebar is nicely aligned. Thanks @astridx


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.

@wilsonge wilsonge merged commit c82c377 into joomla:4.0-dev Oct 19, 2019
@wilsonge
Copy link
Contributor

Thanks!

@Scrabble96
Copy link
Contributor

Thank you :-)

@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 23, 2019
@astridx astridx deleted the cassiopeia-align branch August 9, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet