Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix core loader on RTL #26358

Merged
merged 3 commits into from
Sep 23, 2019
Merged

[4.0] Fix core loader on RTL #26358

merged 3 commits into from
Sep 23, 2019

Conversation

C-Lodder
Copy link
Member

Pull Request for Issue #26356

Summary of Changes

Fix the core-loader web component on RTL

Testing Instructions

  • Modify installation/language/en-GB/en-GB.xml to set it to RTL: <rtl>1</rtl>
  • Install Joomla.

Demo Codepen: https://codepen.io/charlie-lodder/pen/rNBQBev

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 19, 2019
@C-Lodder C-Lodder changed the title Fix core loader on RTL [4.0] Fix core loader on RTL Sep 19, 2019
@infograf768
Copy link
Member

I have tested this item ✅ successfully on bd1d8ad

Works fine. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26358.

@infograf768
Copy link
Member

@wilsonge
Good to go.

@alikon
Copy link
Contributor

alikon commented Sep 19, 2019

I have tested this item ✅ successfully on bd1d8ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26358.

@alikon
Copy link
Contributor

alikon commented Sep 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26358.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 19, 2019
@wilsonge wilsonge merged commit e101500 into joomla:4.0-dev Sep 23, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 23, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 23, 2019
@C-Lodder C-Lodder deleted the patch-2 branch September 23, 2019 09:35
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants