Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Mobile template toolbar #26513

Merged
merged 7 commits into from
Oct 19, 2019
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 7, 2019

This PR contains the markup for a proposed change to the display of the toggled toolbar.

It is does NOT contain the css changes that are required. I really could do with some help with converting the css below to appropriate scss - or even better scss

You can paste the css below into your browser dev tools after applying the PR to see the intended behaviour

Pull Requests welcome to create the scss
Pull Request for Issue #26486

Demo

2019-10-07_20-17-56

This PR contains the markup for a proposed change to the display of the toggled toolbar.

It is does NOT contain the css changes that are required. I really could do with some help with converting the css below to appropriate scss - or even better scss

You can paste the css below into your browser dev tools after applying the PR to see the intended behaviour

Pull Requests welcome to create the scss

@media (max-width: 575.98px) {
  .toggler-toolbar {
      top: 20px;
  }

  .toggler-toolbar.collapsed .toggler-toolbar-icon::before {
      font: normal normal normal 30px/1 'Font Awesome 5 Free';
      content: "\f085";
      color: var(--toggle-color);
  }

  .toggler-toolbar .toggler-toolbar-icon::before {
      font: normal normal normal 30px/1 'Font Awesome 5 Free';
      content: "\f00d";
      color: var(--toggle-color);
  }
  .subhead joomla-toolbar-button, .subhead .btn-group, .subhead .btn {
      width: 100%;
  }
  .subhead .btn [class^='icon-'], .subhead .btn [class*=' icon-'], .subhead .btn [class^='fa-'], .subhead .btn [class*=' fa-'] {
    float: left;
  }
}
@Fedik
Copy link
Member

Fedik commented Oct 8, 2019

@brianteeman place this to /administrator/templates/atum/scss/blocks/_toolbar.scss at bottom and run node build.js --compile-css

@include media-breakpoint-down(xs) {
  .toggler-toolbar {
    top: 20px;

    .toggler-toolbar-icon::before {
      font: normal normal normal 30px/1 'Font Awesome 5 Free';
      content: "\f00d";
      color: var(--toggle-color);
    }

    &.collapsed .toggler-toolbar-icon::before {
      content: "\f085";
    }
  }

  .subhead{

    joomla-toolbar-button,
    .btn-group,
    .btn{
      width: 100%;
    }

    .btn{
      [class^='icon-'],
      [class*=' icon-'],
      [class^='fa-'],
      [class*=' fa-'] {
        float: left;
      }
    }
  }
}

@brianteeman
Copy link
Contributor Author

Thanks @Fedik

@snehaM26
Copy link

I have tested this item 🔴 unsuccessfully on 98a5678

Tested unsuccessfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

@nidhi1709
Copy link

Tested successfully

@nidhi1709
Copy link

I have tested this item ✅ successfully on 98a5678


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

1 similar comment
@snehaM26
Copy link

I have tested this item ✅ successfully on 98a5678


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

@snehaM26
Copy link

I have tested this item ✅ successfully on 98a5678

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

@brianteeman
Copy link
Contributor Author

Codestyle changes applied - thanks@quy

@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@HLeithner HLeithner merged commit cb10e08 into joomla:4.0-dev Oct 19, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@HLeithner
Copy link
Member

Thanks.

@HLeithner HLeithner added this to the Joomla 4.0 milestone Oct 19, 2019
@infograf768
Copy link
Member

Totally dead in RTL where the icons buttons are misplaced (tested after also using PR #26613 which also corrects the place of the toggler)

Screen Shot 2019-10-19 at 10 52 12

@brianteeman brianteeman deleted the mobile-template branch October 19, 2019 15:46
@infograf768
Copy link
Member

Making patch for RTL now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants