-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Mobile template toolbar #26513
Conversation
This PR contains the markup for a proposed change to the display of the toggled toolbar. It is does NOT contain the css changes that are required. I really could do with some help with converting the css below to appropriate scss - or even better scss You can paste the css below into your browser dev tools after applying the PR to see the intended behaviour Pull Requests welcome to create the scss @media (max-width: 575.98px) { .toggler-toolbar { top: 20px; } .toggler-toolbar.collapsed .toggler-toolbar-icon::before { font: normal normal normal 30px/1 'Font Awesome 5 Free'; content: "\f085"; color: var(--toggle-color); } .toggler-toolbar .toggler-toolbar-icon::before { font: normal normal normal 30px/1 'Font Awesome 5 Free'; content: "\f00d"; color: var(--toggle-color); } .subhead joomla-toolbar-button, .subhead .btn-group, .subhead .btn { width: 100%; } .subhead .btn [class^='icon-'], .subhead .btn [class*=' icon-'], .subhead .btn [class^='fa-'], .subhead .btn [class*=' fa-'] { float: left; } }
@brianteeman place this to @include media-breakpoint-down(xs) {
.toggler-toolbar {
top: 20px;
.toggler-toolbar-icon::before {
font: normal normal normal 30px/1 'Font Awesome 5 Free';
content: "\f00d";
color: var(--toggle-color);
}
&.collapsed .toggler-toolbar-icon::before {
content: "\f085";
}
}
.subhead{
joomla-toolbar-button,
.btn-group,
.btn{
width: 100%;
}
.btn{
[class^='icon-'],
[class*=' icon-'],
[class^='fa-'],
[class*=' fa-'] {
float: left;
}
}
}
} |
Thanks @Fedik |
I have tested this item 🔴 unsuccessfully on 98a5678 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513. |
Tested successfully |
I have tested this item ✅ successfully on 98a5678 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513. |
1 similar comment
I have tested this item ✅ successfully on 98a5678 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513. |
I have tested this item ✅ successfully on 98a5678 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513. |
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Codestyle changes applied - thanks@quy |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513. |
Thanks. |
Totally dead in RTL where the icons buttons are misplaced (tested after also using PR #26613 which also corrects the place of the toggler) |
Making patch for RTL now. |
This PR contains the markup for a proposed change to the display of the toggled toolbar.
It is does NOT contain the css changes that are required. I really could do with some help with converting the css below to appropriate scss - or even better scssYou can paste the css below into your browser dev tools after applying the PR to see the intended behaviourPull Requests welcome to create the scssPull Request for Issue #26486
Demo