New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] options grid #26608

Merged

wilsonge merged 1 commit into joomla:4.0-dev from brianteeman:grid

Oct 19, 2019

Contributor

brianteeman commented Oct 16, 2019 •

edited

Most of the options fieldsets have a css class of .options-grid-form-full which means that they should be in one column.

However as can be seen below they are in two uneven columns

The cause of this is the description div which is set to start at col 1 and end at col 3 even though at this resolution there is only 1 column.

.com_config .tab-description {
    grid-column: 1/3;
}

Pull Request for Issue #26605


          [4.0] options grid

c7b7795

Most of the options fieldsets have a css class of .options-grid-form-full which means that they should be in one column.

However as can be seen below they are in **two** uneven columns
![image](https://user-images.githubusercontent.com/1296369/66870244-ebb3b000-ef98-11e9-8711-e80e634b4b48.png)

The cause of this is the description div which is set to start at col 1 and end at col 3 eben though at this resolution there is only 1 column.

```
.com_config .tab-description {
    grid-column: 1/3;
}
```

joomla-cms-bot added the PR-4.0-dev label

Contributor

Quy commented Oct 16, 2019

I have tested this item ✅ successfully on c7b7795

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26608.}

Quy mentioned this pull request

[4.0] options grid #26605

Closed

amit4106udale commented Oct 19, 2019

I have tested this item 🔴 unsuccessfully on c7b7795

Not working with mobile responsive design.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26608.}

Renuka-S commented Oct 19, 2019

I have tested this item 🔴 unsuccessfully on c7b7795

This issue is fixed for the Menu Items > New > Contacts > List all contact categories > Contact display options
But the issue remains for the Menu Items > New > Contacts > List contacts in a category > Contact display options

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26608.}

Contributor Author

brianteeman commented Oct 19, 2019

did you run npm i to rebuild the css after applying the patch? If not then nothing will change

Member

sanderpotjer commented Oct 19, 2019

I have tested this item ✅ successfully on c7b7795

After npm grid is full-width.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26608.}

Quy removed the PR-4.0-dev label

Contributor

Quy commented Oct 19, 2019

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26608.}

joomla-cms-bot added the RTC label

wilsonge merged commit f773f96 into joomla:4.0-dev

Contributor

wilsonge commented Oct 19, 2019

Thanks!

joomla-cms-bot added PR-4.0-dev and removed RTC labels

wilsonge added this to the Joomla 4.0 milestone

Contributor Author

brianteeman commented Oct 19, 2019

thanks

brianteeman deleted the grid branch

October 19, 2019 21:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment