Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Re enable some muted code in Finder #26618

Merged
merged 2 commits into from
Oct 19, 2019
Merged

[4.0] Re enable some muted code in Finder #26618

merged 2 commits into from
Oct 19, 2019

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Oct 17, 2019

Pull Request for Issue # .

Summary of Changes

  • Remove a global var, whoever did this is not my friend (hint: probably I did it)
  • Unmute some code that was closing automatically a modal

Note: The Joomla.Modal API is always on the parent window!!!

(eg if there is an iframe and you need to call it from there you must call it like: window.parent.Joomla.Modal.getCurrent().close())

Testing Instructions

Run npm install !important

Go to http://j4.local/administrator/index.php?option=com_finder&view=index
click on the Index button
The modal SHOULD close automatically at the end of the indexing process

Expected result

Actual result

Documentation Changes Required

No, cleanup

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 17, 2019
@Quy
Copy link
Contributor

Quy commented Oct 17, 2019

The last message flashes quickly as the modal closes. Is this the desired behavior?

@dgrammatiko
Copy link
Contributor Author

The last message flashes quickly as the modal closes. Is this the desired behavior?

Might be the globally applied animations, I didn't notice to be honest...

@snehaM26
Copy link

I have tested this item 🔴 unsuccessfully on 5fb0a6e

Tested this issue


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.

@dgrammatiko
Copy link
Contributor Author

@snehaM26 dis you run ‘npm I’?

@snehaM26
Copy link

I have tested this item 🔴 unsuccessfully on 5fb0a6e

Tested uncessessfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.

@jaydevingawale
Copy link

I have tested this item 🔴 unsuccessfully on 5fb0a6e

it is not closing after the indexing is completed but if we hit the window.parent.Joomla.Modal.getCurrent().close() in console it gets closed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.

@dkmkk
Copy link

dkmkk commented Oct 19, 2019

I have tested this item ✅ successfully on 0c97f8c

I had applied the patch:
I can confirm the expected results.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.

@ahghatol
Copy link

I have tested this item ✅ successfully on 0c97f8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.

@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on 0c97f8c

Modal closes after index finished.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.

@wilsonge
Copy link
Contributor

Merging. But we should keep an eye on the animations I guess

@wilsonge wilsonge merged commit 8c69acb into joomla:4.0-dev Oct 19, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 19, 2019
@dgrammatiko dgrammatiko deleted the 4.0-dev-com_finder branch February 17, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants