-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Re enable some muted code in Finder #26618
Conversation
The last message flashes quickly as the modal closes. Is this the desired behavior? |
Might be the globally applied animations, I didn't notice to be honest... |
I have tested this item 🔴 unsuccessfully on 5fb0a6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
@snehaM26 dis you run ‘npm I’? |
I have tested this item 🔴 unsuccessfully on 5fb0a6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
I have tested this item 🔴 unsuccessfully on 5fb0a6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
I have tested this item ✅ successfully on 0c97f8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
I have tested this item ✅ successfully on 0c97f8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
I have tested this item ✅ successfully on 0c97f8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
Merging. But we should keep an eye on the animations I guess |
Pull Request for Issue # .
Summary of Changes
Note: The
Joomla.Modal
API is always on the parent window!!!(eg if there is an iframe and you need to call it from there you must call it like:
window.parent.Joomla.Modal.getCurrent().close()
)Testing Instructions
Run
npm install
!importantGo to
http://j4.local/administrator/index.php?option=com_finder&view=index
click on the Index button
The modal SHOULD close automatically at the end of the indexing process
Expected result
Actual result
Documentation Changes Required
No, cleanup