Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Create global name ascending string #26798

Merged
merged 2 commits into from Oct 25, 2019

Conversation

brianteeman
Copy link
Contributor

In #26797 I created a global string for "Name ascending" and "Name descending"

This PR uses that global string instead of duplicating the string in each component

testing

This can be tested without #26797 its just that the sort option will be displayed as JGLOBAL_NAME_ASC instead of "Name ascending"

In joomla#26797 I created a global string for "Name ascending" and "Name descending"

This PR uses that global string instead of duplicating the string in each component

### testing
This can be tested without joomla#26797 its just that the sort option will be displayed as JGLOBAL_NAME_ASC instead of "Name ascending"
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Oct 24, 2019
@Quy
Copy link
Contributor

Quy commented Oct 24, 2019

Also update:
System > Update > Extensions
System > Update > Update Sites

@brianteeman
Copy link
Contributor Author

@Quy done

@Quy
Copy link
Contributor

Quy commented Oct 24, 2019

I have tested this item ✅ successfully on 0937049


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26798.

1 similar comment
@joeykrop
Copy link

I have tested this item ✅ successfully on 0937049


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26798.

@Quy
Copy link
Contributor

Quy commented Oct 25, 2019

RFC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26798.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 25, 2019
@wilsonge wilsonge merged commit f77ea18 into joomla:4.0-dev Oct 25, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 25, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 25, 2019
@brianteeman
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants