Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary queries when sending mass mail #26844

Merged
merged 4 commits into from Oct 30, 2019

Conversation

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Oct 28, 2019

Summary of Changes

Removes unnecessary queries when sending mass mail, also fixing query error on PostgreSQL and MS SQL described in #26789.

Testing Instructions

Try sending mass mail. To all groups, to specific group, to group containing only you as user, include/exclude child groups.

Expected result

Error described in #26789 is gone and everything else works like before.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Oct 29, 2019

I have tested this item successfully on 7b1825f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26844.

1 similar comment
@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Oct 29, 2019

I have tested this item successfully on 7b1825f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26844.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Oct 30, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26844.

@joomla-cms-bot joomla-cms-bot added the RTC label Oct 30, 2019
SharkyKZ and others added 2 commits Oct 30, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Oct 30, 2019

Merged last commit by code review. Thanks

@HLeithner HLeithner merged commit 0b0bc41 into joomla:staging Oct 30, 2019
4 checks passed
4 checks passed
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Oct 30, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.13 milestone Oct 30, 2019
@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/query/massmail branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.