Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary queries when sending mass mail #26844

Merged
merged 4 commits into from Oct 30, 2019
Merged

Avoid unnecessary queries when sending mass mail #26844

merged 4 commits into from Oct 30, 2019

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Oct 28, 2019

Summary of Changes

Removes unnecessary queries when sending mass mail, also fixing query error on PostgreSQL and MS SQL described in #26789.

Testing Instructions

Try sending mass mail. To all groups, to specific group, to group containing only you as user, include/exclude child groups.

Expected result

Error described in #26789 is gone and everything else works like before.

@Quy
Copy link
Contributor

Quy commented Oct 29, 2019

I have tested this item ✅ successfully on 7b1825f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26844.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 7b1825f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26844.

@Quy
Copy link
Contributor

Quy commented Oct 30, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26844.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 30, 2019
@HLeithner
Copy link
Member

Merged last commit by code review. Thanks

@HLeithner HLeithner merged commit 0b0bc41 into joomla:staging Oct 30, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 30, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.13 milestone Oct 30, 2019
@SharkyKZ SharkyKZ deleted the j3/query/massmail branch October 30, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants