Removing MooTools dependencies from core.js #2687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oc-mootools-jquery-core Conflicts: media/system/js/core-uncompressed.js media/system/js/core.js
…cided since JHtmlBehavior::framework is getting depreciated in 4.0
|
@AshanFernando I think I will put together a PR in the next days to introduce a new behavior function for core.js. |
|
Did a PR: #2696 |
|
@AshanFernando what do you think about remove any library dependency from core.js ? |
mbabker
pushed a commit
that referenced
this pull request
Mar 9, 2014
|
Merged to |
Bakual
pushed a commit
to Bakual/joomla-cms
that referenced
this pull request
May 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary including JHtml::_('jquery.framework'); until it further decided since JHtmlBehavior::framework is getting depreciated in 4.0
@thomas Hunziker Your suggestion is a good approach to solve the core.js jQuery dependency loading issue, and shall we take more suggestions from the community ?