Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #27080 fix: Incorect id generated for input fields in repetable s… #27081

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@cheetabhai
Copy link
Contributor

cheetabhai commented Nov 15, 2019

Bug #27080

Summary of Changes
For repetable subform if the name of any field in the subform contains hyphen (-) then the id of the clone is not generated correctly.

If we click on (+) button to add the clone of the subform then the id of the field with hyphen (-) in name do not contain correct number of the clone, instead X is shown in the id.

Testing Instructions
Check the value of id attribute of input element in repetable subform after clicking the plus (+) button to add new clone of sub-form with a field having name hyphen (-) in it.

E.g If we have repetable subform field named as 'office-address' then the id of the elements in the cloned set should be like this 'jform_office_address__office_address1__address' but it is generated as 'jform_office_address__office_addressX__address'

Expected result
The value of id attribute of input element should contain clone number and not X

Actual result
The clone number for the field is not getting replaced with X

Documentation Changes Required
no change required in documentation

…ubform (JS Side)
@BPBlueprint

This comment has been minimized.

Copy link

BPBlueprint commented Nov 20, 2019

I have tested this item successfully on 64c3c90

Seems to work!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27081.

@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Nov 21, 2019

I have tested this item successfully on 64c3c90


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27081.

@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Nov 21, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27081.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 21, 2019
@amit4106udale

This comment has been minimized.

Copy link

amit4106udale commented Nov 25, 2019

I have tested this item successfully on ef4ed48

Working with all the editors


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27081.

@HLeithner HLeithner merged commit de3a6f6 into joomla:staging Nov 25, 2019
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/drone/pr Build encountered an error
Details
JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Nov 25, 2019

thx

@joomla-cms-bot joomla-cms-bot removed the RTC label Nov 25, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.14 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.