[4.0] Fixing switcher label for true/false

[Quy]

Pull Request for Issue #26749.

Summary of Changes

In Global Configuration, 0/1 are saved as true/false. Read #26749 (comment)
false cast as string returns empty string and true returns 1.
Assign it 0 so it can match the option value 0.

			<option value="0">JNO</option>
			<option value="1">JYES</option>

Testing Instructions

Go to Global Configurations
See Site Offline missing label
Apply PR
Make sure switcher labels not missing

Open configuration.php
Toggle Site Offline
Make sure $offline is saved as true or false

[ChristineWk]

I have tested this item ✅ successfully on f17349d

Toggled Site Offline. configuration.php > public $offline=true;

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[vaibhavsTekdi]

I have tested this item ✅ successfully on f17349d

Working fine as per the mentioned "Testing instructions".

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[SharkyKZ]

RTC.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[infograf768]

@HLeithner
is that OK for you?

[HLeithner]

I'm still not sure if this is the proper way to do this. But yeah if it's the best solution to resolve the problem. Shouldn't this be done in the model/formfield layer and not in the layout?

[HLeithner]

Forget my comment I mixed 2 pr's it seams to be ok.

[wilsonge]

In this specific case wondering if we actually should have this in the form. normally this is correct. However in the normal (non-switcher) radio field it may not be.

[Quy]

It is working now for switcher and non-switcher.

[HLeithner]

Changing this in the Jformfield would mean that this is valid for all abstracted classes, that means if I have a input field I get a '0' instead of an empty string correct? (if the function is not overridden)

I wouldn't expect this.

[Quy]

It is checking for a false value. Empty string does not apply.
To test, apply PR. See Path to Cache Folder field where it is empty. It does not display 0.

[HLeithner]

thats true but if the value is false it would convert it also for a text field into '0' and not ''

[Quy]

It is a strict comparison for boolean and false. A string value will not be affected.

[infograf768]

@Quy
You mean that when we have:

			<option value="true">JYES</option>
			<option value="false">JNO</option> 

It would have no impact?

[Quy]

I am not at a computer to test but it should not be affected because it is string and not boolean.

[Quy]

Also this applies to the configuration file only when storing true/false values if I am not wrong. It has been a while since doing this PR. My memory not so good these days.

[Fedik]

I wounder how it may have RTC 😉

Doing if ($this->value === false) globally in FormField is incorrect, it will affect every field.

That maybe better to do after #27202 will be merged

[brianteeman]

Works perfectly for me. I dont see any issues.

@Fedik please post exactly where it breaks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[brianteeman]

I have tested this item ✅ successfully on 72e779b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[brianteeman]

I can't comment about the code but it solves the problem

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[Fedik]

please post exactly where it breaks

People tested it with switcher field, but this changes:

will affect every field

this may lead to unexpected behavior, when example some extension have a custom field,
which expect value to be boolean false, and we force it to be string '0'.

[infograf768]

Took off RTC until @Fedik comment is taken care of.

[infograf768]

setting to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27098.}

[brianteeman]

@Fedik could you please provide a specific example

[Fedik]

I do not have a specific example to demonstrate, it a logic assumption that comes from the code review.

If we need this hacky thing, then better to do it specifically for the switcher field, not global.

There a couple ways:
Or move this hacky code to the switcher layout itself layouts/joomla/form/field/radio/switcher.php
Or fix these two conditions to work correctly:

joomla-cms/layouts/joomla/form/field/radio/switcher.php

Lines 73 to 77 in a9f80d6

	<?php
	// Initialize some option attributes.
	$checked = ((string) $option->value == $value) ? 'checked="checked"' : '';
	$active = ((string) $option->value == $value) ? 'class="active"' : '';
	$oid = $id . $i;

[Quy]

Is this better?

[Fedik]

much better 😉

[wilsonge]

I mean it's grim. But much better than the initial code change. So merging. Thankyou!