Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JSON Document caching #27161

Merged
merged 1 commit into from Dec 5, 2019
Merged

Allow JSON Document caching #27161

merged 1 commit into from Dec 5, 2019

Conversation

@wilsonge
Copy link
Contributor

wilsonge commented Nov 26, 2019

Summary of Changes

Allows the caching of JSON Documents if something requests it. In webservice custom applications (e.g. the Joomla Downloads Site) this is an important optimisation (and will be required in J4 whether accepted in j3 or not)

In order to keep behaviour I've ensured that both com_config and com_finder do not cache the response under any circumstance

Testing Instructions

N/A - There's no change in behaviour for core components. Ensure finder works the same before and after patch

Documentation Changes Required

JSON Responses can be cached

@HLeithner HLeithner added this to the Joomla! 3.9.14 milestone Nov 27, 2019
@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Dec 5, 2019

I have tested this item successfully on 9f02876


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27161.

@HLeithner HLeithner merged commit 97122dc into joomla:staging Dec 5, 2019
4 of 5 checks passed
4 of 5 checks passed
JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Dec 5, 2019

Thanks

@wilsonge wilsonge deleted the wilsonge:bug/json-caching branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.