Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Change plugin statistics popup to be alertdialog #27189

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Dec 1, 2019

Pull Request for Issue #22507 .

Summary of Changes

The plugin statistics popup should not have a role=alert as this role does not allow for a response by the user, instead it should have a role=alertdialog.

Testing Instructions

Enable System - Joomla! Statistics plugin.
View markup of the popup.
See role="alert".
Apply PR.
See role="alertdialog".

@Quy Quy added the PR-4.0-dev label Dec 1, 2019
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4f55581


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Dec 2, 2019

I have tested this item ✅ successfully on 4f55581


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189.

@alikon
Copy link
Contributor

alikon commented Dec 2, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 2, 2019
@Quy Quy added the PR-4.0-dev label Dec 2, 2019
@wilsonge wilsonge merged commit f510d2c into joomla:4.0-dev Dec 2, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Dec 2, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 2, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Dec 2, 2019
@Quy Quy deleted the 22507-alertdialog branch December 2, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants