Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plg_quickicon_phpversioncheck] Avoid errors when Joomla! gets outdated #27197

Merged

Conversation

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Dec 2, 2019

Pull Request for Issue #27195.

Summary of Changes

Fixes error that occurs when PHP version is unsupported and outdated Joomla! version doesn't know a recommended PHP version.

Testing Instructions

See #27195 (comment).

Expected result

No errors.

Actual result

Call to a member function format() on null

Documentation Changes Required

No.

@ReLater

This comment has been minimized.

Copy link
Contributor

ReLater commented Dec 2, 2019

I have tested this item successfully on f99404e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27197.

@Quy Quy added the PR-staging label Dec 2, 2019
@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Dec 2, 2019

I have tested this item successfully on f524109


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27197.

@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Dec 2, 2019

RTC
previous test is still good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27197.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 2, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Dec 5, 2019

Thanks for the better php EOL support sharky

@HLeithner HLeithner merged commit 2e12668 into joomla:staging Dec 5, 2019
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/drone/pr Build is failing
Details
JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner HLeithner added this to the Joomla! 3.9.14 milestone Dec 5, 2019
@joomla-cms-bot joomla-cms-bot added Language Change and removed RTC labels Dec 5, 2019
@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/error/plg_quickicon_phpversioncheck branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.