Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plg_quickicon_phpversioncheck] Avoid errors when Joomla! gets outdated #27197

Merged
merged 3 commits into from Dec 5, 2019
Merged

[plg_quickicon_phpversioncheck] Avoid errors when Joomla! gets outdated #27197

merged 3 commits into from Dec 5, 2019

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Dec 2, 2019

Pull Request for Issue #27195.

Summary of Changes

Fixes error that occurs when PHP version is unsupported and outdated Joomla! version doesn't know a recommended PHP version.

Testing Instructions

See #27195 (comment).

Expected result

No errors.

Actual result

Call to a member function format() on null

Documentation Changes Required

No.

@ReLater
Copy link
Contributor

ReLater commented Dec 2, 2019

I have tested this item successfully on f99404e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27197.

@Quy Quy added the PR-staging label Dec 2, 2019
@alikon
Copy link
Contributor

alikon commented Dec 2, 2019

I have tested this item successfully on f524109


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27197.

@joomla-cms-bot joomla-cms-bot removed the Language Change label Dec 2, 2019
@alikon
Copy link
Contributor

alikon commented Dec 2, 2019

RTC
previous test is still good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27197.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 2, 2019
@HLeithner
Copy link
Member

HLeithner commented Dec 5, 2019

Thanks for the better php EOL support sharky

@HLeithner HLeithner merged commit 2e12668 into joomla:staging Dec 5, 2019
3 of 5 checks passed
@HLeithner HLeithner added this to the Joomla! 3.9.14 milestone Dec 5, 2019
@joomla-cms-bot joomla-cms-bot added Language Change and removed RTC labels Dec 5, 2019
@SharkyKZ SharkyKZ deleted the j3/error/plg_quickicon_phpversioncheck branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants