Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notice on Joomla update with PHP 7.4 #27219

Merged
merged 2 commits into from Dec 8, 2019

Conversation

degobbis
Copy link
Contributor

@degobbis degobbis commented Dec 7, 2019

Pull Request for Issue # .

Summary of Changes

A PHP Notice will be shown on Joomla Update with PHP 7.4.
This Patch solves this notice.

Testing Instructions

Needs Joomla 3.9.13 and PHP 7.4 installed
Go to Joomla administration -> Components -> Joomla! Update and -> Check for Updates

Expected result

An Update or the actual version for reinstallation will bi shown, without any PHP notices

Actual result

PHP Notice will shown

@brianteeman
Copy link
Member

brianteeman commented Dec 7, 2019

I have tested this item successfully on a4dd3cd

Replicated the issue and confirm the test does what it says


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27219.

@degobbis
Copy link
Contributor Author

degobbis commented Dec 7, 2019

@brianteeman thx for testing

@viocassel
Copy link
Contributor

viocassel commented Dec 7, 2019

I have tested this item successfully on a4dd3cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27219.

@Quy
Copy link

Quy commented Dec 7, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27219.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 7, 2019
@degobbis
Copy link
Contributor Author

degobbis commented Dec 8, 2019

@viocassel thx for testing

@zero-24 zero-24 added this to the Joomla! 3.9.14 milestone Dec 8, 2019
@zero-24
Copy link
Member

zero-24 commented Dec 8, 2019

Merging thanks for fixing this issue 👍

@zero-24 zero-24 merged commit e78eebf into joomla:staging Dec 8, 2019
5 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC label Dec 8, 2019
@degobbis degobbis deleted the FixNoticeOnJoomlaUpdatePHP74 branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants