Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] com_media. Show full video filename and preview icon #27230

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@ReLater
Copy link
Contributor

ReLater commented Dec 9, 2019

Pull Request for Issue #27221

Summary of Changes

  • Remove truncate(...) for video filename.
  • Add missing echo for preview image (icon).

Actual result

Testing Instructions

  • See first post of #27221
  • Apply patch.

Expected result

  • Check if full videeo filename is displayed.
  • Check if Video preview icon is displayed.
@ReLater ReLater changed the title Show full video filename and preview icon [3.9] com_media. Show full video filename and preview icon Dec 9, 2019
@ChristineWk

This comment has been minimized.

Copy link

ChristineWk commented Dec 9, 2019

I have tested this item successfully on a3b994c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27230.

1 similar comment
@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Dec 9, 2019

I have tested this item successfully on a3b994c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27230.

@Quy Quy removed the PR-staging label Dec 9, 2019
@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Dec 9, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27230.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 9, 2019
@Quy Quy added the PR-staging label Dec 9, 2019
@HLeithner HLeithner merged commit 123c7ea into joomla:staging Dec 9, 2019
5 checks passed
5 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Dec 9, 2019

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC label Dec 9, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.14 milestone Dec 9, 2019
@ReLater ReLater deleted the ReLater:patch-1 branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.