Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix for 27192 #27255

Merged
merged 3 commits into from
Jan 4, 2020
Merged

[4.0] Fix for 27192 #27255

merged 3 commits into from
Jan 4, 2020

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #27192 .

Summary of Changes

More options added to cropperjs

Testing Instructions

Read the detailed explanation in the issue

Expected result

Actual result

Documentation Changes Required

NO, bug fix

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Dec 13, 2019
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ded63df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27255.

@brianteeman
Copy link
Contributor

Thanks Dmitiris - I assumed it would use the plugin and not directly or I would have worked it out. doh


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27255.

@Quy
Copy link
Contributor

Quy commented Dec 13, 2019

I have tested this item ✅ successfully on ded63df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27255.

@Quy
Copy link
Contributor

Quy commented Dec 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27255.

@Quy Quy added the RTC This Pull Request is Ready To Commit label Dec 13, 2019
@wilsonge wilsonge merged commit 9612901 into joomla:4.0-dev Jan 4, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Jan 4, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 4, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 4, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
@dgrammatiko dgrammatiko deleted the patch-4 branch February 17, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants