Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute URLs in action logs #27432

Merged
merged 5 commits into from Jan 22, 2020
Merged

Use absolute URLs in action logs #27432

merged 5 commits into from Jan 22, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jan 8, 2020

Fixes #27431.

Summary of Changes

Use absolute URLs for links in action log emails.

Testing Instructions

Make sure Force HTTPS option in Global Configuration is disabled.
As super admin, edit your profile. Enable Send notifications for User Actions Log option.
Perform a loggable action (e.g. edit an article).
Try clicking the links in the action notification email.

Expected result

Links take you to your Joomla! website.

Actual result

Links don't work.

Documentation Changes Required

No.

@Sulpher
Copy link

Sulpher commented Jan 8, 2020

"Make sure Force HTTPS option in Global Configuration is disabled."

Why so? There are a lot of websites with SSL.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Jan 8, 2020

The issue is reproducible only when Force HTTPS is disabled.

@Sulpher
Copy link

Sulpher commented Jan 8, 2020

The issue is reproducible only when Force HTTPS is disabled.

I opened the administrator panel via http:// (no SSL) and Force HTTPS is set to None.
However, the issue occurs.
Then I opened the back-end via https:// and set Force HTTPS to Entire site.
The email is consists of correct URLs and there is no issue described above.

The conclusion: the problem could happen with the sites without SSL...

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Jan 8, 2020

Yes, the issue occurs when Force HTTPS is set to None (i.e. disabled).

@Sulpher
Copy link

Sulpher commented Jan 8, 2020

Thanks for the PR!

@Quy
Copy link
Contributor

Quy commented Jan 20, 2020

I have tested this item ✅ successfully on f046f5b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27432.

@Quy
Copy link
Contributor

Quy commented Jan 20, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27432.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 20, 2020
@HLeithner HLeithner merged commit 6b00883 into joomla:staging Jan 22, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 22, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.15 milestone Jan 22, 2020
@SharkyKZ SharkyKZ deleted the patch-3 branch January 22, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Actions Log notification to be sent on email: problem with URLs
5 participants