Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix nested tabs not working in com_config #27507

Merged
merged 3 commits into from
Jan 15, 2020
Merged

[4.0] Fix nested tabs not working in com_config #27507

merged 3 commits into from
Jan 15, 2020

Conversation

C-Lodder
Copy link
Member

Pull Request for Issue #27188

Summary of Changes

Fix the com_config view so that nested fieldsets are displayed properly.

Testing Instructions

  1. Go to administrator/index.php?option=com_config
  2. Select "Articles" from the sidebar menu
  3. Go to the "Integrations" tab

Expected result

72211043-31124b80-34bc-11ea-86a9-672dce975e65

Actual result

72211050-3ff8fe00-34bc-11ea-9989-62f4b731f379

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 17df359

Thanks the functionality has now been restored


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27507.

@Quy
Copy link
Contributor

Quy commented Jan 13, 2020

I have tested this item ✅ successfully on 17df359


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27507.

@Quy Quy removed the PR-4.0-dev label Jan 13, 2020
@Quy
Copy link
Contributor

Quy commented Jan 13, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27507.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2020
@Quy
Copy link
Contributor

Quy commented Jan 13, 2020

@C-Lodder Please check the Permissions tab as the table is indented.

@Quy Quy removed the RTC This Pull Request is Ready To Commit label Jan 13, 2020
@Quy
Copy link
Contributor

Quy commented Jan 13, 2020

I have tested this item ✅ successfully on 717a234


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27507.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 717a234


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27507.

@Quy
Copy link
Contributor

Quy commented Jan 13, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27507.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2020
@wilsonge wilsonge merged commit c53dda9 into joomla:4.0-dev Jan 15, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 15, 2020
@wilsonge
Copy link
Contributor

Thanking you muchly kind sir ;)

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 15, 2020
@C-Lodder C-Lodder deleted the fix-config branch January 15, 2020 07:55
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants