[4.0] [Cassiopeia] Remove header SVG curve

[ciar4n]

Pull Request for Issue #27565 .

Summary of Changes

Removes the SVG curve from the frontend template header

Testing Instructions

Apply patch and run node build.js --compile-css to update the changed SCSS.

Add banner module to banner position

Before PR

Banner cropped by SVG

After PR

Banner is visible

Documentation Changes Required

No

[infograf768]

Great.
Remains one aspect: the Module Class. What do we do with that?

[ciar4n]

Not sure I understand what you mean. Is it missing from the output?

[infograf768]

Is it missing from the output?

As far as I see , yes.

[infograf768]

I think it comes from
<jdoc:include type="modules" name="banner" style="xhtml" />

Cardgrey and default chromes contain <?php echo htmlspecialchars($params->get('moduleclass_sfx')

not xhtml

[ciar4n]

I've changed the style to html5 which appears to be the only chrome with no styling and adds the class. It appears default applies card styling to the module which is incorrect imo and possibly needs changing (separate issue/pr).

[infograf768]

On ipad, will test later.
In j3, chromes are defined in system.
Except for the specific chromes which are defined in the template itself, do you have an idea where are defined html5 and xhtml in j4 ?

[ciar4n]

System chromes are in ../layouts/chromes/

[infograf768]

I have tested this item ✅ successfully on bdcce04

Looks fine here.

we get <div class="moduletable mybannerclass"> which is fine.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.}

[infograf768]

@ciar4n
Looks like we have also another xhtml style in error.php

<?php if ($this->countModules('banner')) : ?>
		<div class="grid-child container-banner">
			<jdoc:include type="modules" name="banner" style="xhtml" />
		</div>

[ChristineWk]

I have tested this item ✅ successfully on aee0cc4

Tested hours before, but after applying Patch, I got error 404 and: Call to undefined method Joomla\CMS\WebAsset\WebAssetManager::usePreset()
Then I found: brianteeman@7fa8d42
My site was from oct2019, therefore checked above files. Finally installed now completely new nightly build from today.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.}

[jwaisner]

I have tested this item ✅ successfully on aee0cc4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.}

[infograf768]

tks

[Scrabble96]

Sorry, I know the original issue was posted by me, but I'm unable to test this; I'm waiting for a new computer :-( which should arrive sometime next week.