Import the user plugins for onUserLoginFailure

[pasamio]

The onUserLoginFailure trigger is a user plugin method however on the failure code path, it isn't loaded. So this changes that to put it on the main code path ahead of the failure check.

[betweenbrain]

Thanks Sam!

This seems like a logical fix. Is there a tracker item for this and/or
testing instructions?

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Jan 6, 2014 12:37 PM, "Sam Moffatt" notifications@github.com wrote:

The onUserLoginFailure trigger is a user plugin method however on the
failure code path, it isn't loaded. So this changes that to put it on the

main code path ahead of the failure check.

You can merge this Pull Request by running

git pull https://github.com/pasamio/joomla-cms patch-1

Or view, comment on, or merge it at:

#2761
Commit Summary

• Import the user plugins for onUserLoginFailure

File Changes

• M libraries/cms/application/cms.phphttps://github.com/Import the user plugins for onUserLoginFailure #2761/files#diff-0(6)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/2761.patch
• https://github.com/joomla/joomla-cms/pull/2761.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2761
.

[pasamio]

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=33103

[roland-d]

@test: works as expected. After applying the patch the onUserLoginFailure() is triggered in the frontend.

Is this supposed to be triggered in the backend as well?

There is a CS issue in the PR:

:10: trailing whitespace.
JPluginHelper::importPlugin('user');
warning: 1 line adds whitespace errors.

[pasamio]

Fixed the whitespace error.