Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Module Assignment menu function accessibility #27635

Closed

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Jan 25, 2020

This PR addresses some of the issues for #23911

Specifically numbers
2, 4, 6

There are others that need to be addressed relating to the actual lists themselves but I a not sure if the list is even remotely accessible so wish to tackle that in a desperate issue

This PR addresses some of the issues for joomla#23911

Specifically numbers
2, 4, 6

There are others that need to be addressed relating to the actual lists themselves but I a not sure if the list is even remotely accessible so wish to tackle that in a deperate issue
@Quy
Copy link
Contributor

Quy commented Jan 25, 2020

Out of curiosity, should there be a space before All so screenreaders don't read them as one word?
<span class="sr-only">Expand</span>All

@infograf768
Copy link
Member

Out of curiosity, should there be a space before All so screenreaders don't read them as one word?

In any case, it looks like this is not compatible with languages where the order would be different, i.e. where the equivalent of the Select verb has to be placed after the All or None object.

I'm afraid the only solution is to create new strings of the type:
COM_MODULES_EXPAND_ALL etc.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Feb 21, 2020
@brianteeman
Copy link
Contributor Author

Changed the approach to use an aria-label instead as it will allow better translation as highlighted by @infograf768
Also re-ordered the language file

@brianteeman
Copy link
Contributor Author

Could someone please fix drone

@HLeithner
Copy link
Member

@brianteeman can you merge the latest changes into this branch please?

@brianteeman
Copy link
Contributor Author

@HLeithner its not showing me that option or any merge issues

image

@HLeithner
Copy link
Member

@brianteeman I have no idea why it doesn't work can you create a new PR please?

@HLeithner HLeithner closed this Mar 5, 2020
@brianteeman brianteeman deleted the drupal_cprint_weekend3 branch March 6, 2020 13:02
@brianteeman
Copy link
Contributor Author

Done see #28250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants