Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Changing UI for com_mails list view #27704

Merged
merged 5 commits into from
Feb 5, 2020
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 29, 2020

Pull Request for Issue #26489.

Summary of Changes

The UI of the mail template manager was not intuitive and a concern for a beta release. This attempts to change this to something that people can understand better. The changes are:

  • The language column only displays the languages for which a customised template exists. Should find a better title for that column, I guess...
  • To create or edit a template, you click on the title and get a dropdown to select the language that you want to edit.

Testing Instructions

This is a proposal, so I'm looking for feedback on the useability of this.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 29, 2020
@Hackwar
Copy link
Member Author

Hackwar commented Jan 29, 2020

@brianteeman, @infograf768 Your opinions about this? As I wrote in other areas, this should indeed be improved and it would be a pity if we have to drop this whole feature for the 4.x series.

@brianteeman
Copy link
Contributor

@Hackwar its much better but there are still some issues to address

  1. I think it would be useful to know if there are languages where the template doesn't exist yet - so I guess another column?

  2. As there is no template for language ALL that option needs to be removed from the filter

  3. On the edit mail template there should be a visual indicator what language you are creating a template for - perhaps
    image

  4. It is not clear to me from the UI when you need to create the template for a language AND if you only create the template for one language will that be used for all languages or will the other languages use the core

@brianteeman
Copy link
Contributor

OR would it be helpful to have the ability to create a template for Language - ALL

@Hackwar
Copy link
Member Author

Hackwar commented Jan 29, 2020

1. I think it would be useful to know if there are languages where the template doesn't exist yet - so I guess another column?

The idea is, that the dropdown says "Create template for language X" if there is none or "Edit template for language X" if there is one.

2. As there is no template for language ALL that option needs to be removed from the filter

Yes.

3. On the edit mail template there should be a visual indicator what language you are creating a template for - perhaps

Right now I want to concentrate on the list view. The edit view is another issue and I'd like to handle that as a different PR as well. But I will keep this in mind. You are right.

4. It is not clear to me from the UI when you need to create the template for a language AND if you only create the template for one language will that be used for all languages or will the other languages use the core

It will always use the default translation strings given or whatever the devs insert in the field of the default entry for that template ID, unless you created a customisation for a specific language. It is not going to be used for other languages.

Generally, what would an ALL template look like? I can't really come up with something that wouldn't be covered by the translation strings already...

@brianteeman
Copy link
Contributor

brianteeman commented Jan 29, 2020

  1. The dropdown is fine and it works well but it won't work well when you have a large number of templates to configure hence the additional suggestion of the column

  2. OK - its an easy fix

It will always use the default translation strings given or whatever the devs insert in the field of the default entry for that template ID, unless you created a customisation for a specific language. It is not going to be used for other languages.

Let me ask that a different way. On a site with English, French and German and I only create a French template - what will an english or german user see?

@Hackwar
Copy link
Member Author

Hackwar commented Jan 29, 2020

1. The dropdown is fine and it works well but it won't work well when you have a large number of templates to configure hence the additional suggestion of the column

I'm not sure I follow you here... Basically, the dropdown would contain a row for every language, so unless you have 10+ languages in your site, you are pretty fine...

It will always use the default translation strings given or whatever the devs insert in the field of the default entry for that template ID, unless you created a customisation for a specific language. It is not going to be used for other languages.

Let me ask that a different way. On a site with English, French and German and I only create a French template - what will an english or german user see?

If you don't have a customised template for a language, the system falls back onto what is stored in the default template for that template id. That normally would be a translation key, which would then again be in some language file, which hopefully is already loaded.

@brianteeman
Copy link
Contributor

I'm not sure I follow you here... Basically, the dropdown would contain a row for every language, so unless you have 10+ languages in your site, you are pretty fine...

That is fine when you are only dealing with one template. Now imagine you have twenty templates and five languages. By adding the extra column to indicate the languages on the site that do not have a customisation then you can quickly see without having to click on each of the 20 dropdowns

@Hackwar
Copy link
Member Author

Hackwar commented Jan 29, 2020

Hmm, I would argue that it is easier to see when we don't have that second column. Let me break into a large and very pseudo-scientific explanation, which I'm then going to cut short with another argument. 😛

The human eye can see rythm changes rather well. I would assume that it is rather easier to see if in a group of 5 icons two are missing, than when you have 3 icons in column one and 2 icons in column two. (With a site that has 5 languages installed)
Now for the argument to cut all this short: We don't have this second column for language article associations either, so why do we need it here?

@brianteeman
Copy link
Contributor

I will counter that with an image of the multilingual associations component ui

image

@Hackwar
Copy link
Member Author

Hackwar commented Jan 29, 2020

damn, you got me. Fair enough.

@brianteeman
Copy link
Contributor

:)

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Jan 30, 2020
Adds the language code to the displayed title when editing a mail template. As discussed in joomla#27704
@brianteeman
Copy link
Contributor

@Hackwar I made a pr for this part #27723
image

Quy pushed a commit that referenced this pull request Jan 31, 2020
Adds the language code to the displayed title when editing a mail template. As discussed in #27704

Co-authored-by: Quy <quy@fluxbb.org>
@Hackwar
Copy link
Member Author

Hackwar commented Feb 4, 2020

Second columm has been added. I'm open for a better wording...

@brianteeman
Copy link
Contributor

thanks - i cant think of anything else right now for the text

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on eadfa2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27704.

1 similar comment
@drmenzelit
Copy link
Contributor

I have tested this item ✅ successfully on eadfa2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27704.

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Adds the language code to the displayed title when editing a mail template. As discussed in joomla#27704

Co-authored-by: Quy <quy@fluxbb.org>
@Quy
Copy link
Contributor

Quy commented Feb 5, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27704.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@rdeutz rdeutz merged commit e3a8f87 into joomla:4.0-dev Feb 5, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@rdeutz rdeutz added this to the Joomla 4.0 milestone Feb 6, 2020
@Hackwar Hackwar deleted the j4mail branch February 17, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants