[RFC][4.0] Full Screen Content edit #27802
Conversation
|
@uglyeoin You were asking for something like this before I think |
|
@brianteeman thanks for remembering me. I was more concerned about modules possibly appearing above the editing window making it confusing. I wonder if this solved both problems. Happy to test when Inger a few moments. |
|
@uglyeoin as it is right now it wont but the same concept can easily be applied there |
|
@uglyeoin you can now test this for modules as well. - looks ugly but this is still just a draft for review |
|
Sure, happy to test. Thanks for the contribution there is much we can improve. |
|
"It's so simple that I am wondering if I missed something obvious." Brian: You are catching along of these things - rightly so. This is/would be an excellent improvement for F/E content editing. Goes right along with my "thing" about Articles being at the bottom of the list - the most used content item type for menu link items, requires a scroll action to get to it vs. having it on top by just naming it with an "A ..." before the name. You have a sharp eye for this stuff and hope that others will also align with your observations and make the changes you offer. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27802. |
Quy
changed the title
|
It will fix this issue #26944 |
|
@Quy only as a side effect and not as intended behaviour |
|
@uglyeoin I thought you might have found the time to check this out by now - please |
|
@brianteeman I can't get patchtester to install, I assume it's possible just to overwrite the files? |
|
Ok I tried overwriting the files but my version of J4 doesn't have them in that location. If you can assist me I will try to test this. Looks like a very simple change so it shouldn't be hard to get it tested. |
|
thats a limitation of using patchtester instead of git when files get moved. The file that has moved is now at administrator\components\com_content\src\Service\HTML\Icon.php |
|
But that directory doesn't exist for me when I use the latest nightly build. Patch tester doesn't install. I tried doing it manually. |
|
then you cannot be using the latest nightly build (or the build is broken) because all the files moves were made 2 days ago |
|
I have updated this PR to use the moved files for you |
|
Ok thanks, I'll just download this Zip and try that |
|
I got it here so maybe worth checking if I'm getting it from the right place or if there's a problem https://developer.joomla.org/nightly-builds.html |
|
@brianteeman sorry to be a pain, I'm really not sure what I'm doing here. Can I just click on "code" and download that Zip or is there something else I need to do? |
|
since i updated the pr then patchtester will work - I just confirmed it on my install |
|
Oh I see. I can't install patch tester though. Hence me looking for the files manually.
|
|
that I have no idea about. It looks terrible - its just to see if the concept is ok before spending time on the styling |
|
I have tested this item ✅ successfully on 954ccd2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27802. |
|
Thanks for testing it. I will do some more work on it tomorrow so that it doesn't look so ugly and will work with any template. |
|
@brianteeman |
|
This is a POC and request for feedback |
|
Closed due to lack of interest |
|
That's a shame I thought it was a valid improvement |
This is a POC and request for feedback
Introduction
Front end editing is a second class experience in joomla. Depending on your template the available area to edit your content can be very narrow. It is also distracting to have the rest of the site visible when trying to edit the content.
This incredibly simple pull request makes the edit form open full screen with nothing else to distract you.
When you save or cancel the edit you are correctly returned to the previous page.
It's so simple that I am wondering if I missed something obvious
Demo video before this PR
Demo video with this PR