[4.0] Admin modules - edit links #27843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infograf768
reviewed
Feb 7, 2020
|
I have tested this item ✅ successfully on 0c9fb34 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27843. |
1 similar comment
|
I have tested this item ✅ successfully on 0c9fb34 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27843. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27843. |
|
thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 9, 2020
* [4.0] Admin modules - titles * copy paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26322
Summary of Changes
On the home page of the backend there are several modules that display information.
...
In these modules the link is missing a title attribute, which describes to the user where the link is leading to. In the manage overviews there is a title attribute on the links, which is only called e.g. "edit test".
I believe the thinking behind the current text was that it "made sense" in the context of the row. I appreciate that it makes less sense in the context of a list of links that a screen reader might generate
The same issue is present with actionlogs but that's a bigger issue and needs its own pr