Use query builder in JUpdater->findUpdates() #2787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 12, 2014 14:56
Changing $query to use Joomla querybuilder Also changing the subselect to a inner join and properly process the query if $eid is passed as a single integer
|
@test successfull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions
Make sure that Joomla updates and extensions updates are found after the patch is applied.
Proposed Changes
$queryto use the querybuilder.$eidis passed as a single integer. Currently it is expected as an array of integers and will do no filtering at all if a single integer is passed instead of an array. Instead it will search for updates in all sites, slowing down the process. We pass a single integer in some places, like in the Joomla Update component. Thus this should be a bit faster with this patch.