Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch the potential DB errors when "#__postinstall_messages" is missing #2840

Closed
wants to merge 1 commit into from

Conversation

jms2win
Copy link
Contributor

@jms2win jms2win commented Jan 24, 2014

Based on comment from bakual in PR 2822, I have move this PR from master to staging and also included the enhancement frm mbabker
#2821

Based on comment from bakual in PR 2822, I have move this PR from master to staging and also included the enhancement frm mbabker
@Bakual
Copy link
Contributor

Bakual commented Jan 24, 2014

Changed title of the PR to the title of the original PR.
Also adding here the description of original PR:

When we proceed with a manual upgrade from Joomla 2.5.17 to J3.2.1 by an unzip of J3.2.1 full package over a current J2.5.17 installation, the #__postinstall_messages is not present and cause the impossibility to login due to the "cPanel" that always abort on DB Error.

The purpose of this fix is to intercept such kind of errors and let the cPanel displayed without any "Post Install Messages".

Comment history can be seen in original PR.

@jms2win
Copy link
Contributor Author

jms2win commented Jan 24, 2014

Sorry but I don't understand what you want that I do and where.

The title of which PR do you want that I change ?
The exact number please.

I think that I have clearly identified in the new PR that I have created at your request and it makes reference to this one (PR).
So all the information can be retrieved and also from the Bugtracker as this one also make reference to the new PR

If you want to add comments in the new PR to make them more clear, this is possible.

Do you want that I add a comment in the Bugtracker to mentioned the new PR, this is also possible but you can do it also.

Sorry but I am not fluent with PR.

@Bakual
Copy link
Contributor

Bakual commented Jan 24, 2014

All well 👍

@infograf768
Copy link
Member

This has to be updated to present state of staging

@sovainfo
Copy link
Contributor

Although I agree with this being done for the wrong reason (bad migration strategy as mentioned by @brianteeman ) I would like this to be extended to the complete RAD layer, not only the database problem.

Expect the Control Panel to be fault tolerant and not to fail just because one of its components fail.

@roland-d
Copy link
Contributor

@jms2win Could you please update to the latest staging? Thanks.

@jms2win
Copy link
Contributor Author

jms2win commented Mar 1, 2015

@roland-d can you be more precise of what you expect from me.
I don't understand what I have to do.
I see that that travis did something and that somebody seems want that I comit something but I don't know where and how to do that.
If you are admin, can you acknowledge this very old pull request

@zero-24
Copy link
Contributor

zero-24 commented Mar 1, 2015

@jms2win if you don't know how you can update to staging or fix merge conflicts. You can simple close here and open a new PR against staging. The problem is that the file you what to patch is changed since you open the PR. So we can't merge it. 😄

@jms2win
Copy link
Contributor Author

jms2win commented Mar 1, 2015

@zero-24
OK - I will close as nobody had a look on it on more than 1 year and that I don't know how to manage the merge.
So I let you apply the change.

@zero-24
Copy link
Contributor

zero-24 commented Mar 2, 2015

done here: #6252 Thanks @jms2win


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2840.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants