Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [RFC] Custom select Icons instead of SVGs #28787

Closed
wants to merge 12 commits into from

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Apr 25, 2020

Draft as basis for a discussion because of #28680 (comment) and #28755 (comment) .
(alternative for #28755 and #28680).
Also see:#28673

Summary of Changes

I implemented an idea of how we can use an Icon Font instead of SVGs

Testing Instructions

At the moment this is a RFC.

Basically I prefer SVGs. But I think that the maintenance in an open source project with an icon font is easier.

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev RFC Request for Comment labels Apr 25, 2020
@coolcat-creations
Copy link
Contributor

As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure

@C-Lodder
Copy link
Member

So all <select> elements need to be wrapped within a parent <div> to have a custom icon?

@infograf768
Copy link
Member

As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure

svg are a pity to cope with, specially as background as we can't modify the color except if we create other svgs.
Icons are much much easier to deal with for devs/ bug fix

@Quy
Copy link
Contributor

Quy commented Apr 25, 2020

What about the frontend? It should not be dependent of fontawesome.

@astridx
Copy link
Contributor Author

astridx commented May 10, 2020

I just resolved a conflict in this draft. I became aware of the topic again. I think we just need a decision here. Otherwise, a contributor will do something that someone else will undo because he likes something else ...

These solutions are in my opinion technically better than this draft:
#28262
#28351

I made this draft because I think the solution in the draft is easier. Sometimes this is also advantageous (#28787 (comment)).

@coolcat-creations
As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure

Thank you for your feedback. You sure know more than I do. I wonder why you yourself continue to work with icon fonts instead of proposing a solution with SVGs: https://github.com/joomla/joomla-cms/pull/29016/files

@Quy What about the frontend? It should not be dependent of fontawesome.

You're right. Thank you Quy. But this draft is only about Atum, i.e. the backend.

@C-Lodder So all <select> elements need to be wrapped within a parent <div> to have a custom icon?

Yes. But in the case of https://github.com/jshjohnson/Choices, an already existing div is used.

@Quy
Copy link
Contributor

Quy commented May 10, 2020

But this draft is only about Atum, i.e. the backend.

But why do it differently on the backend and frontend for the same thing?

@astridx
Copy link
Contributor Author

astridx commented May 10, 2020

@astridx
Copy link
Contributor Author

astridx commented Jul 4, 2020

My solution is not a good one. I'm closing this here. #28673 is not solved and should be reopened.

@astridx astridx closed this Jul 4, 2020
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jul 4, 2020
@astridx astridx deleted the custom-select-playaround branch August 9, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester RFC Request for Comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants