-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [RFC] Custom select Icons instead of SVGs #28787
Conversation
administrator/components/com_modules/layouts/joomla/form/field/modulespositionedit.php
Show resolved
Hide resolved
As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure |
So all |
svg are a pity to cope with, specially as background as we can't modify the color except if we create other svgs. |
What about the frontend? It should not be dependent of fontawesome. |
I just resolved a conflict in this draft. I became aware of the topic again. I think we just need a decision here. Otherwise, a contributor will do something that someone else will undo because he likes something else ... These solutions are in my opinion technically better than this draft: I made this draft because I think the solution in the draft is easier. Sometimes this is also advantageous (#28787 (comment)).
Thank you for your feedback. You sure know more than I do. I wonder why you yourself continue to work with icon fonts instead of proposing a solution with SVGs: https://github.com/joomla/joomla-cms/pull/29016/files
You're right. Thank you Quy. But this draft is only about Atum, i.e. the backend.
Yes. But in the case of https://github.com/jshjohnson/Choices, an already existing div is used. |
But why do it differently on the backend and frontend for the same thing? |
My solution is not a good one. I'm closing this here. #28673 is not solved and should be reopened. |
Draft as basis for a discussion because of #28680 (comment) and #28755 (comment) .
(alternative for #28755 and #28680).
Also see:#28673
Summary of Changes
I implemented an idea of how we can use an Icon Font instead of SVGs
Testing Instructions
At the moment this is a RFC.
Basically I prefer SVGs. But I think that the maintenance in an open source project with an icon font is easier.