[4.0] Nested fieldsets #29398
Closed
[4.0] Nested fieldsets #29398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR stops splitting nested fieldsets using the params layout from being split again into columns
|
See similar PR #28790 |
|
@Quy that one still splits into columns and would still cause the problems reported elsewhere |
|
Yes, then we run into issue #27672 with one column. |
|
See George's comment: #28790 (comment) |
|
Not with this pr |
|
OK. Let me test it later and report back. |
|
Before PR: After PR: So #27672 and George's comment #28790 (comment) are related. |
|
Then my code is wrong. The intention was that it would only stop nested fieldsets from splitting in to columns but keep the columns on the non-nested fieldsets |
|
Similar changes have to be done as #28790 but for one column. See Edit article > Configure Edit Screen where it is 2 columns and should be 1 for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops splitting nested fieldsets using the params layout from being split again into columns
Possible solution to #29388 and #29254
before
after
I have not checked to see if there are other places where this happens other than the example in the screenshot with com_tags