Fix ordering of language strings #29836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid someone "fixing" this again could you add a comment in the file |
|
Thanks |
I'd rather remove the strings completely (if they aren't already in J4) since they actually aren't used anymore. |
|
@Bakual in the next 2.5 years of supported life for j3 I'm sure someone will try to fix this ;) |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jul 10, 2020
Новые константы, вышла 3.9.20 RC joomla/joomla-cms#29836 joomla/joomla-cms#29566 joomla/joomla-cms#29683 joomla/joomla-cms#29612 joomla/joomla-cms#29445
Reconix
pushed a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
This reverts commit 548e8b7.
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
This reverts commit 548e8b7.
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
This reverts commit d5c055a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue https://crowdin.com/translate/joomla-cms/1250/engb-fr#46173
Summary of Changes
While language strings should be alpha ordered, the strings which are only plural forms of eachother have to stay together. Otherwise tools like Crowdin get issues. So don't blindly alpha-order :-)
Testing Instructions
Nothing really to test as it's just moving a language string few lines higher.
Can be merged on review.