Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33222] # Config not outputing error messages when a required field is not fille... #3026

Closed
wants to merge 25 commits into from

Conversation

@n9iels
Copy link
Contributor

n9iels commented Feb 28, 2015

@test I can't reproduce the bug. When I edit my config.xml, I can't save the file without fill it out. When I go to another tab, I also get a message


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3026.

@pe7er
Copy link
Contributor

pe7er commented Feb 28, 2015

Could you please add a step-by-step testing procedure, including screen shots with arrows & annotations?
That way the issue + your patch will be easier to test.
Could you please respond within 30 days, otherwise this issue will be closed.
Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3026.

@compojoom
Copy link
Contributor Author

The reproduce steps that I've posted on joomlacode are still correct for Cmandrill & cmc.
However if you want to reproduce this with com_content, since we now have js validation you should modify the view files & remove the validation there.

To make things easier, let's test with CMandrill.
First download CMandrill from:
https://compojoom.com/downloads/official-releases-stable/mandrill

then install it. Now go to components -> CMandrill options. Go to the permissions tab and try to change any permission. Save. The page will refresh without any error message and the permissions that you've applied shouldn't be saved.

Now apply the patch and try to save the config again. This time you'll see the error message.

Michael Babker and others added 3 commits March 14, 2015 10:59
[fix] only define constants if they are not defined
Added text wrapping to tooltip in installation template CSS
Remove files that are still there after an upgrade from 2.5 to 3.x
@compojoom
Copy link
Contributor Author

Okay, the above description is wrong. We have now javascript validation and running into the issue is a little difficult.
First we need to disable the javascript validation. Go to:
administrator\components\com_config\view\component\tmpl\default.php
comment out line 23,24 & 27. At the end your code should look like this:

Joomla.submitbutton = function(task)
    {
//      if (task === "config.cancel.component" || document.formvalidator.isValid(document.getElementById("component-form")))
//      {
            Joomla.submitform(task, document.getElementById("component-form"));
//      }
    };

After that test it with CMandrill:
First download CMandrill from:
https://compojoom.com/downloads/official-releases-stable/mandrill

then install it. Now go to components -> CMandrill options. Go to the permissions tab and try to change any permission. Save. The page will refresh without any error message and the permissions that you've applied shouldn't be saved.

Now apply the patch and try to save the config again. This time you'll see the error message.

Michael Babker and others added 6 commits March 14, 2015 11:16
…form-layout

This fixes the front-end form alignment in the protostar template.
Cleaning com_media allowed and ignored extensions whitespaces
since nobody has a better proposal, I'm pushing this code for review...
@joomla-cms-bot joomla-cms-bot changed the title # Config not outputing error messages when a required field is not fille... [#33222] # Config not outputing error messages when a required field is not fille... Mar 14, 2015
@compojoom
Copy link
Contributor Author

I've somehow managed to screw the pull request with another pull request.
Closing this and will open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet