Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Clean up com_users forms #30796

Merged
merged 1 commit into from Sep 29, 2020
Merged

[4.0] Clean up com_users forms #30796

merged 1 commit into from Sep 29, 2020

Conversation

SharkyKZ
Copy link
Contributor

Fixes #30794.

Summary of Changes

Removes form field layout override.
Removes useless descriptions from Profile plugin.
Removes use of non-existing strings.
Adds "strength meter" to password reset form.

Testing Instructions

Inspect all forms in com_users.

Actual result BEFORE applying this Pull Request

In user profile form, the description for Username field is missing.

Expected result AFTER applying this Pull Request

Mostly looks the same, but Username field in profile form now has a description: If you want to change your username, please contact a site administrator..

Documentation Changes Required

No.

@ceford
Copy link
Contributor

ceford commented Sep 29, 2020

I have tested this item ✅ successfully on 5e98b7d

All the forms I looked at seemed normal. The Username description was present.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30796.

@ohrionmartin
Copy link
Member

I have tested this item ✅ successfully on 5e98b7d

System Information

php: Linux orion 5.4.0-48-generic #52-Ubuntu SMP Thu Sep 10 10:58:49 UTC 2020 x86_64
dbserver: mysql
dbversion: 8.0.21-0ubuntu0.20.04.4
dbcollation: utf8mb4_0900_ai_ci
dbconnectioncollation: utf8mb4_0900_ai_ci
dbconnectionencryption:
dbconnencryptsupported: true
phpversion: 7.4.3
server: Apache/2.4.41 (Ubuntu)
sapi_name: apache2handler
version: Joomla! 4.0.0-beta4 Beta [ Mañana ] 15-September-2020 13:46 GMT
useragent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30796.

@Quy Quy removed Language Change This is for Translators PR-4.0-dev labels Sep 29, 2020
@Quy
Copy link
Contributor

Quy commented Sep 29, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30796.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 29, 2020
@Quy Quy added the PR-4.0-dev label Sep 29, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Sep 29, 2020
@zero-24 zero-24 merged commit 2c35db1 into joomla:4.0-dev Sep 29, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Sep 29, 2020
@zero-24
Copy link
Contributor

zero-24 commented Sep 29, 2020

Merging thanks.

@SharkyKZ SharkyKZ deleted the j4/cleanup/com-users-forms branch September 29, 2020 16:00
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants