[4.0] media manager transparent preview #30870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The media manager uses a background of checked squares in the thumbnail view which is useful when you have a transparent image such as the joomla_black.png However in the preview it uses a solid white background which hides most of this image. This pr replaces the white background with the checked squares Dont forget to run npm ci
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on b12d7ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30870. |
1 similar comment
|
I have tested this item ✅ successfully on b12d7ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30870. |
joomla-cms-bot
removed
the
NPM Resource Changed
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30870. |
joomla-cms-bot
added
RTC
|
Thanks |
joomla-cms-bot
added
NPM Resource Changed
|
thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
The media manager uses a background of checked squares in the thumbnail view which is useful when you have a transparent image such as the joomla_black.png However in the preview it uses a solid white background which hides most of this image. This pr replaces the white background with the checked squares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The media manager uses a background of checked squares in the thumbnail view which is useful when you have a transparent image such as the joomla_black.png
However in the preview it uses a solid white background which hides most of this image.
This pr replaces the white background with the checked squares
Dont forget to run npm ci
Before
After