Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] yubikey text #30879

Merged
merged 1 commit into from
Oct 7, 2020
Merged

[4.0] yubikey text #30879

merged 1 commit into from
Oct 7, 2020

Conversation

brianteeman
Copy link
Contributor

don't display the heading additionally in the body

Pull Request for Issue #30874

don't display the heading additionally in the body
@Quy
Copy link
Contributor

Quy commented Oct 2, 2020

I have tested this item ✅ successfully on 0dec0db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30879.

@AndyGaskell
Copy link
Contributor

I had a quick look at testing this, but it seemed like you'd not be able to test it unless you owned a physical YubiKey, which I don't. Text change sounds good though.

@brianteeman
Copy link
Contributor Author

@AndyGaskell just enable the plugin and then go to your user profile in the admin

@AndyGaskell
Copy link
Contributor

@brianteeman Yea, I tried that, but can't see this text. I guess, with the text being...
Your YubiKey is already linked to your user account.
...you have to have a YubiKey already, then try to add another, or something like that. I'm not so familiar with YubiKey stuff, though it's a cool idea and bit of hardware.

yubikey_screen

@joomlacorner
Copy link
Contributor

I have tested this item ✅ successfully on 0dec0db

tested with Yubikey worked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30879.

@Quy
Copy link
Contributor

Quy commented Oct 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30879.

@Quy Quy removed Language Change This is for Translators PR-4.0-dev labels Oct 7, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 7, 2020
@Quy Quy added the PR-4.0-dev label Oct 7, 2020
@HLeithner HLeithner merged commit 850c896 into joomla:4.0-dev Oct 7, 2020
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Oct 7, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Oct 7, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
don't display the heading additionally in the body
@brianteeman brianteeman deleted the yk19 branch January 7, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants