Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33256] downloaded vcard is empty #3088

Merged
merged 2 commits into from
Feb 21, 2014
Merged

[#33256] downloaded vcard is empty #3088

merged 2 commits into from
Feb 21, 2014

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Feb 11, 2014

@MATsxm
Copy link

MATsxm commented Feb 12, 2014

Able to reproduce then #3088 works and was able to download vCard without error

I wasn't able to open the .vcf file but seems to be a personnal config prob and not a corrupt file. - thanks

set 1st successfultest on Tracker
You may blame the J!Tracker Application for transmitting this comment.

@Narimm
Copy link

Narimm commented Feb 13, 2014

I was able to reproduce the empty VCARD
I applied #3088
I was able to produce the vCard
I was able to open the VCF file
The VCF was not corrupt and was readable by windows contacts.
you can set 2nd test

(I assume we dont worry about e_Strict Errors)

You may blame the J!Tracker Application for transmitting this comment.

@Bakual
Copy link
Contributor

Bakual commented Feb 13, 2014

(I assume we dont worry about e_Strict Errors)

Actually we do. What error did you see?

@Narimm
Copy link

Narimm commented Feb 14, 2014

Strict standards: Declaration of ContactViewContact::display() should be compatible with that of JViewLegacy::display() in C:\wamp\www\JoomlaMasterBranch\components\com_contact\views\contact\view.vcf.php on line 17

1 0.9988 374792 {main}( ) ..\index.php:0
2 1.1069 4091088 JApplicationCms->execute( ) ..\index.php:40
3 1.1069 4091088 JApplicationSite->doExecute( ) ..\cms.php:255
4 1.4476 7832384 JApplicationSite->dispatch( ) ..\site.php:208
5 1.4653 7917592 JComponentHelper::renderComponent( ) ..\site.php:178
6 1.4758 7939400 JComponentHelper::executeComponent( ) ..\helper.php:332
7 1.4763 7985768 require_once( 'C:\wamp\www\JoomlaMasterBranch\components\com_contact\contact.php' ) ..\helper.php:352
8 1.4858 8382576 JControllerLegacy->execute( ) ..\contact.php:15
9 1.4858 8382624 ContactController->display( ) ..\legacy.php:722
10 1.4859 8384432 JControllerLegacy->display( ) ..\controller.php:41
11 1.4861 8384808 JControllerLegacy->getView( ) ..\legacy.php:640
12 1.4862 8384984 JControllerLegacy->createView( ) ..\legacy.php:855
13 1.5017 8420584 require_once( 'C:\wamp\www\JoomlaMasterBranch\components\com_contact\views\contact\view.vcf.php' ) ..\legacy.php:604

Thats the call stack and error. Mind you I know I saw in the Joomla PLT Team docs they are aiming for STRICT Compliance, but I assumed other testers had seen this and were ignoring it...I did mention it in the JTracker post I made.
You may blame the J!Tracker Application for transmitting this comment.

@mbabker
Copy link
Contributor Author

mbabker commented Feb 14, 2014

That's fixed now too.

@radiant-tech
Copy link
Contributor

Both issues (uninitialized $app and strict standards error) will need to be corrected in the 2.5.x version as well.

mbabker added a commit that referenced this pull request Feb 21, 2014
[#33256] downloaded vcard is empty
@mbabker mbabker merged commit 032b785 into joomla:staging Feb 21, 2014
@mbabker mbabker deleted the 33256 branch February 21, 2014 00:02
Bakual pushed a commit to Bakual/joomla-cms that referenced this pull request May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants