Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Add generic AJAX error message translation #30909

Merged
merged 1 commit into from
Oct 4, 2020
Merged

[4] Add generic AJAX error message translation #30909

merged 1 commit into from
Oct 4, 2020

Conversation

PhilETaylor
Copy link
Contributor

Pull Request for Issue #30896

Summary of Changes

Add dependancy so that generic Ajax error messages are translated.

Testing Instructions

see #30896

Actual result BEFORE applying this Pull Request

error is untranslated JLIB_JS_AJAX_ERROR_OTHER

Expected result AFTER applying this Pull Request

94988693-70fbf000-056f-11eb-878a-f5aeb8af77f7

Documentation Changes Required

None

@infograf768

@infograf768
Copy link
Member

I have tested this item ✅ successfully on d6b66ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30909.

@brianteeman
Copy link
Contributor

Surely this was supposed to be handled in the js here

@PhilETaylor

This comment was marked as abuse.

@infograf768
Copy link
Member

Restarted drone.

@ceford
Copy link
Contributor

ceford commented Oct 4, 2020

I have tested this item ✅ successfully on d6b66ca

I can confirm the error message is translated. But ... what does 'An error has occurred while fetching the JSON data: HTTP 0 status code.' actually mean to the user?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30909.

@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30909.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 4, 2020
@Quy Quy added the PR-4.0-dev label Oct 4, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 4, 2020
@zero-24 zero-24 merged commit 2c1532b into joomla:4.0-dev Oct 4, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 4, 2020
@zero-24
Copy link
Contributor

zero-24 commented Oct 4, 2020

Merged thanks @PhilETaylor I have added the label and the tag so that should help you geting the shirt right?

@PhilETaylor

This comment was marked as abuse.

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants