Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds \ to all defines #31294

Closed
wants to merge 7 commits into from
Closed

Adds \ to all defines #31294

wants to merge 7 commits into from

Conversation

N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Nov 1, 2020

Pull Request for Issue # .

Summary of Changes

using \define speeds things up.
several places were missing the \ This corrects that.

Testing Instructions

make sure J! still runs.
code review?

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@brianteeman
Copy link
Contributor

a PR that touches over 2700 files is impossible to test

@brianteeman
Copy link
Contributor

Why are you deleting .github/SECURITY.md

@N6REJ
Copy link
Contributor Author

N6REJ commented Nov 1, 2020

Why are you deleting .github/SECURITY.md

I'm not... it was deleted in #30778
image

@brianteeman
Copy link
Contributor

No it wasn't and yes you are.

image

image

@brianteeman
Copy link
Contributor

You are also deleting

image

@brianteeman
Copy link
Contributor

And adding an unrelated svg

image

@brianteeman
Copy link
Contributor

Every file in the fof folder that you have changed need to have their copyright updated if it does not already do so

* @note This file has been modified by the Joomla! Project and no longer reflects the original work of its author.

@N6REJ
Copy link
Contributor Author

N6REJ commented Nov 1, 2020

@brianteeman might wanna check staging before you blame me for everything.. I didn't add anything

@N6REJ
Copy link
Contributor Author

N6REJ commented Nov 1, 2020

after reviewing several files I"m closing this as it's changing things that I didn't change.

@N6REJ N6REJ closed this Nov 1, 2020
@N6REJ N6REJ deleted the defined_j3 branch November 1, 2020 22:31
@brianteeman
Copy link
Contributor

git doesnt lie

@N6REJ
Copy link
Contributor Author

N6REJ commented Nov 1, 2020

your full of crap @brianteeman #30778 is the cause of all that.. check the damn logs!!
image

@N6REJ
Copy link
Contributor Author

N6REJ commented Nov 1, 2020

you owe me an apology
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants