Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Select article etc button styling #31363

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Nov 8, 2020

When we have two buttons joined together visually it is important that a user can determine that there are two buttons and not just one big button with two pieces of text. This is important for those with cognitive issues etc

Before

image

image

After

image

image

Testing

You can find this field when you create a menu item for a single article

Also included in this PR are the identical change for the category, contact, menu and newsfeed fields

cc @carcam as requested

@brianteeman brianteeman changed the title [4.0] Select article etc styling [4.0] Select article etc button styling Nov 8, 2020
@infograf768
Copy link
Member

Propagate button is only modified for articles. Missing for contacts, categories, menu items, newsfeeds

Before PR

Articles

articles_associations

Menu items

menuitemsassociations

After PR

Articles

articlesassocafter

Menu items

menuitemsassocafter

@brianteeman
Copy link
Contributor Author

@infograf768 Thanks for finding somewhere that the propagate button changed - I couldnt find it. I will take another look now you found a working example.

@ceford
Copy link
Contributor

ceford commented Nov 9, 2020

Propagate button? I have never seen that. How is it produced?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31363.

@brianteeman
Copy link
Contributor Author

@ceford its part of creating a menu item on a multilingual site and found in the associations tab

@infograf768 should be fixed now

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 9d706c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31363.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Nov 11, 2020

I have tested this item ✅ successfully on 9d706c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31363.

@Quy
Copy link
Contributor

Quy commented Nov 11, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31363.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 11, 2020
@infograf768 infograf768 merged commit c86c963 into joomla:4.0-dev Nov 12, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 12, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Nov 12, 2020
@infograf768
Copy link
Member

Tks.

@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the select_article branch November 12, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants