Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Finder pagination options #31390

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

This PR adds support for the two pagination options

PR for #31316

image

image

This PR adds support for the two pagination options
@particthistle
Copy link
Member

I have tested this item ✅ successfully on 651f1c9

Determined testing requirements from reading through #31316. Change tested successfully.

Testing Instructions

Create a Smart Search Menu item, with a low limit (5) on the number of results to show on the page to trigger the pagination when it's turned on.

Actual result BEFORE applying this Pull Request

Pagination displays when setting is set to Hide for either the Pagination and Pagination Summary options are set to Hide

Actual result AFTER applying this Pull Request

When Pagination and/or Pagination Summary options are set to various options, particularly Hide, the pagination options will adhere to what the settings is configured to do.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31390.

@ceford
Copy link
Contributor

ceford commented Nov 13, 2020

I have tested this item ✅ successfully on 651f1c9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31390.

1 similar comment
@sakiss
Copy link
Contributor

sakiss commented Nov 13, 2020

I have tested this item ✅ successfully on 651f1c9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31390.

@alikon
Copy link
Contributor

alikon commented Nov 13, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31390.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Nov 13, 2020
@alikon
Copy link
Contributor

alikon commented Nov 13, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31390.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 13, 2020
@Quy Quy added the PR-4.0-dev label Nov 13, 2020
@Quy Quy added this to the Joomla 4.0 milestone Nov 13, 2020
@Quy Quy merged commit 081c4c7 into joomla:4.0-dev Nov 13, 2020
@Quy
Copy link
Contributor

Quy commented Nov 13, 2020

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 13, 2020
@brianteeman
Copy link
Contributor Author

thx

@brianteeman brianteeman deleted the finder_results branch November 13, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants