Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Incorrect language constant in installation files #31487

Merged
merged 3 commits into from Nov 26, 2020
Merged

[4.0] Incorrect language constant in installation files #31487

merged 3 commits into from Nov 26, 2020

Conversation

Kostelano
Copy link
Contributor

Summary of Changes

When installing Joomla 4, select the PostgreSQL type and enter the database name that starts with a number.

We get an error.

Screenshot_1

The constant appears two times in the files below.

Screenshot_2

PR fixes the problem.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 25, 2020
@Quy
Copy link
Contributor

Quy commented Nov 25, 2020

I have tested this item ✅ successfully on fb32c79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.

@brianteeman
Copy link
Contributor

An alternative that would avoid all the translations to be updated would be to update the constant in the two places it is used in the code

@ghost
Copy link

ghost commented Nov 26, 2020

I have tested this item ✅ successfully on fb32c79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.

@infograf768
Copy link
Member

Agree with @brianteeman
please rather modify

/Applications/MAMP/htdocs/newfolder/joomla40/installation/src/Helper/DatabaseHelper.php:238: 			return Text::_('INSTL_DATABASE_NAME_MSG_POSTGRESQL');
/Applications/MAMP/htdocs/newfolder/joomla40/libraries/src/Console/SetConfigurationCommand.php:314: 			$this->ioStyle->error(Text::_('INSTL_DATABASE_NAME_MSG_POSTGRESQL'));

to use INSTL_DATABASE_NAME_MSG_POSTGRES

@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Nov 26, 2020
@Kostelano
Copy link
Contributor Author

DONE.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on be2d3b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on be2d3b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.

@infograf768 infograf768 added the Language Change This is for Translators label Nov 26, 2020
@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2020
@wilsonge wilsonge merged commit 721d709 into joomla:4.0-dev Nov 26, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators RTC This Pull Request is Ready To Commit labels Nov 26, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants