New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Rebuild the image filter to a registry allowing custom filters outside the main namespace #31818
base: 5.2-dev
Are you sure you want to change the base?
Conversation
…e the main namespace
Co-authored-by: Quy <quy@fluxbb.org>
Tried to create a custom image and add a custom filter to the Registry of the CustomImage class, which is in another namespace, e.g. Inside a Plugin in /plugins/system/
I also tried to replace the registry of the Image class with a custom Registry in another namespace, The Image class expects the registry to be of type
registry replacement snippet, in which the custom registry provides a custom brightness filter, but fails
Appended the source code for the plugin |
This pull request has automatically rebased to 4.2-dev. |
This pull requests has been automatically converted to the PSR-12 coding standard. |
@wilsonge what are we doing with this PR? |
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible. |
This pull request has been automatically rebased to 5.1-dev. |
This pull request has been automatically rebased to 5.2-dev. |
Pull Request for Issue #31804 .
Summary of Changes
Refactor the image filter class to have custom namespaces by using a registry for loading classes.
Why is this b/c changing at this stage?
Because there is a poor user experience for third party extensions who'd have to custom autoload code to add custom filters (as evidenced by the fact we were doing this in our own tests until yesterday)
Testing Instructions
Documentation Changes Required
Yup - refactor the namespaced stuff.