Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Modal close rtl #32137

Merged
merged 1 commit into from Jan 24, 2021
Merged

[4.0] Modal close rtl #32137

merged 1 commit into from Jan 24, 2021

Conversation

brianteeman
Copy link
Contributor

Apply PR
rebuild css

The modal close X is now correctly in the top left and with correct margins

image

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 24, 2021
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 46a5432


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32137.

1 similar comment
@ghost
Copy link

ghost commented Jan 24, 2021

I have tested this item ✅ successfully on 46a5432


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32137.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 24, 2021
@alikon
Copy link
Contributor

alikon commented Jan 24, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32137.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 24, 2021
@infograf768 infograf768 merged commit 0555b2c into joomla:4.0-dev Jan 24, 2021
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Jan 24, 2021
@infograf768 infograf768 added this to the Joomla 4.0 milestone Jan 24, 2021
@brianteeman brianteeman deleted the 35sun branch January 24, 2021 10:41
@wilsonge
Copy link
Contributor

I think we can delete the .close class at the top of the file which was the old class for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants