Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by ldap_uid when binding as user (#32399) #32400

Closed
wants to merge 2 commits into from

Conversation

oantby
Copy link

@oantby oantby commented Feb 12, 2021

Pull Request for Issue #32399.

Summary of Changes

Switch from searching by search_string, which is described as not required for bind-as-user, to building a filter based on the ldap_uid attribute laid out in settings.

Testing Instructions

  1. Enable LDAP plugin
  2. Set to bind directly as the user, and fill out required configuration, leaving search_string blank.
  3. set display_errors to On
  4. Go to administrative login
  5. Attempt to log in as a user who is valid in LDAP, but is not authorized to access Joomla!

Actual result BEFORE applying this Pull Request

Along with the authentication failure message, a php error message is displayed indicating an invalid LDAP filter.

Expected result AFTER applying this Pull Request

Only the intended authentication failure message is displayed.

Documentation Changes Required

None, to my knowledge.

@zero-24
Copy link
Contributor

zero-24 commented Jun 12, 2022

i will not merge this PR here into 3.10. i see where you are comming from but in oder to keep b/c with the current implementation i will keep it as it is. please sync the setting of the search string with the ldap_uid setting for now that should result into the same behavior.

thanks :-)

@zero-24 zero-24 closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants