[4.0] Pagination set to bottom after voting #32914

rjharishabh · 2021-03-28T21:35:09Z

Pull Request for Issue #32909.

Testing Instructions

Enable Content - Vote plugin with Bottom option selected
Enable Voting in Article options
Visit an article

Actual result BEFORE applying this Pull Request

content then pagination then voting

Expected result AFTER applying this Pull Request

content then voting then pagination

Documentation Changes Required

No

rjharishabh · 2021-03-29T03:35:58Z

@PhilETaylor please test this PR

rjharishabh · 2021-03-29T08:11:38Z

@PhilETaylor Thnx for testing

ghost · 2021-03-29T08:15:12Z

@SharkyKZ can i ask you please why you sometimes give a "thumps-down" without a comment? i'm interested about reasons for thumps-down but without a word its for me a strange behaviour.

rjharishabh · 2021-03-29T08:17:21Z

@SharkyKZ can i ask you please why you sometimes give a "thumps-down" without a comment? i'm interested about reasons for thumps-down but without a word its for me a strange behaviour.

same question @SharkyKZ

rjharishabh · 2021-03-29T17:05:26Z

Please test this PR @ceford

ceford · 2021-03-29T17:31:57Z

I have tested this item ✅ successfully on 0e1f307

I had to enable the Vote plugin and position it below - then the PR works as described and it is clearly more logical for Vote to appear above Next/Previous than below.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32914.}

rjharishabh · 2021-03-29T17:51:05Z

Thnx for testing

Quy · 2021-03-29T19:35:42Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32914.}

Quy · 2021-03-29T21:35:33Z

I assume by moving it that it is no longer afterDisplayContent.

rjharishabh · 2021-03-29T22:49:04Z

I assume by moving it that it is no longer afterDisplayContent.

I think it's related to voting

rjharishabh · 2021-03-31T17:44:05Z

@Quy
is there anything that I have to change

infograf768 · 2021-04-01T10:20:40Z

There is a reason @SharkyKZ thumbed down... Just add an image in the article and look at the stars placement.

Before patch

After patch

joomdonation · 2021-04-01T10:33:45Z

Trust me there was not... he just went to all my PR's and did it. its obviously personal. He did it to a load of other PRs within seconds too.

I don't think so. I don't know why he is not happy with Joomla! now but from what I see, most of the time, @SharkyKZ is usually right with his thumb down.

joomdonation · 2021-04-01T10:41:05Z

If I get his thumb down for my PR, I would look at my code again to see if I could make any mistake :D.

rjharishabh · 2021-04-01T11:19:35Z

He should be given some feedback on how to improve

infograf768 · 2021-04-01T12:01:53Z

All the PR did was move the stars from after the pagination (which is completely the wrong place for it) to above the pagination. If then the css needs tweaking at a template level it should be.

So be it, but in the same PR. It may also need to insert the code into a div.

rjharishabh · 2021-04-14T13:33:40Z

@infograf768 @Quy
please test

It's looking better now.

ghost · 2021-04-16T07:44:16Z

I have tested this item ✅ successfully on 9c699ae

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32914.}

infograf768 · 2021-04-16T08:28:15Z

This needs some margin/padding when no images, displayed in blog and placed at bottom.

ghost · 2021-04-16T08:53:01Z

@infograf768 i had made an issue #33164

rjharishabh · 2021-04-16T09:40:01Z

when I am testing the output is this

ghost · 2021-04-16T09:44:33Z

@rjharishabh you have to look at the blog-menu, not the article-view.

sandewt · 2021-04-16T09:51:22Z

when I am testing the output is this

Are you using the latest version of J4? In the last few days several changes have been merged to the vote plugin !

rjharishabh · 2021-04-16T09:54:30Z

when I am testing the output is this

Are you using the latest version of J4? In the last few days, several changes have been merged to the vote plugin!

This branch is not updated.
How can I update this branch with the latest changes? Please help @sandewt

sandewt · 2021-04-16T10:23:21Z

How can I update this branch with the latest changes? Please help @sandewt

See: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment

Install: composer, node.js and git

In Windows, I use the cmd prompt to clone the latest Joomla 4 version.

git clone https://github.com/joomla/joomla-cms.git -b 4.0-dev /xampp/htdocs/bugtesting/joomla

I would like to hear if it could be simpler !?

rjharishabh · 2021-04-16T10:26:44Z

the 4.0-dev branch is updated with new changes
but the PR branch pagination is not updated
So how can I pagination branch with the new changes?

drmenzelit · 2021-04-16T10:27:33Z

I don't think this PR is correct: changing the position of afterDisplayContent has effects on all plugins using this event. For me the "pagination" = navigation between articles is part of the content, so afterDisplayContent should be below the pagination.

brianteeman · 2021-04-16T10:38:34Z

I don't think this PR is correct: changing the position of afterDisplayContent has effects on all plugins using this event. For me the "pagination" = navigation between articles is part of the content, so afterDisplayContent should be below the pagination.

Correct. Changing it here will change every plugin using afterDisplayContent

ghost · 2021-04-16T10:44:26Z

the voting should be before the pagination

agree

drmenzelit · 2021-04-16T11:33:33Z

The implementation in this PR of the fix for #32909 may be incorrect, but Im sure we can all agree that the voting should be before the pagination and not after it like it is currently as per the screenshots here #32909

I agree with that, but we have to find another way than moving the afterDisplayContent

rjharishabh · 2021-04-16T12:55:59Z

The implementation in this PR of the fix for #32909 may be incorrect, but Im sure we can all agree that the voting should be before the pagination and not after it like it is currently as per the screenshots here #32909

I agree with that, but we have to find another way than moving the afterDisplayContent

Yes, I agree

sandewt · 2021-04-17T15:36:11Z

Has anyone looked at joomla 3 and worked out how it's done there?

The same issue, see image.

sandewt · 2021-04-17T17:45:06Z

I don't think this PR is correct: changing the position of afterDisplayContent has effects on all plugins using this event. For me the "pagination" = navigation between articles is part of the content, so afterDisplayContent should be below the pagination.

What do you think of this minor adjustment? afterDisplayContent direct before pagination

Now

if (!empty($this->item->pagination) && $this->item->paginationposition && $this->item->paginationrelative) :
	echo $this->item->pagination;
?>
<?php endif; ?>
<?php // Content is generated by content plugin event "onContentAfterDisplay" ?>
<?php echo $this->item->event->afterDisplayContent; ?>

Proposal

<?php // Content is generated by content plugin event "onContentAfterDisplay" ?>
<?php echo $this->item->event->afterDisplayContent; ?>
<?php
if (!empty($this->item->pagination) && $this->item->paginationposition && $this->item->paginationrelative) :
	echo $this->item->pagination;
?>

rjharishabh · 2021-04-18T05:07:46Z

@sandewt This PR is the same as your proposal.

sandewt · 2021-04-18T05:33:14Z

@sandewt This PR is the same as your proposal.

Yes, but the voting (content plugin) is loaded immediately before the pagination. So, no other actions are happening in the meantime. Or am I wrong?

[EDIT] Oops, I cannot reproduce my suggestion 😅

sandewt · 2021-04-23T12:05:43Z

This needs some margin/padding when no images, displayed in blog and placed at bottom.

#33164 (comment)

pagination after voting

0e1f307

joomla-cms-bot added the PR-4.0-dev label Mar 28, 2021

Quy mentioned this pull request Mar 28, 2021

[4] Voting set to bottom is after pagination #32909

Closed

rjharishabh changed the title ~~Pagination set to bottom after voting~~ [4.0] Pagination set to bottom after voting Mar 28, 2021

This comment was marked as abuse.

Sign in to view

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 29, 2021

Quy added this to the Joomla 4.0 milestone Mar 29, 2021

Quy removed the RTC This Pull Request is Ready To Commit label Mar 29, 2021

joomla-cms-bot removed this from the Joomla 4.0 milestone Mar 29, 2021

rjharishabh mentioned this pull request Apr 1, 2021

[4.0] css changes in voting plugin #32919

Merged

This comment was marked as abuse.

Sign in to view

sandewt mentioned this pull request Apr 14, 2021

[4.0] Improvement Vote Plugin #31098

Merged

rjharishabh added 2 commits April 14, 2021 18:30

star with form

b5f0ade

corrected

3baf0ca

rjharishabh added 2 commits April 16, 2021 09:40

w-auto added

271f146

conflict

9c699ae

This comment was marked as abuse.

Sign in to view

rjharishabh closed this Apr 17, 2021

This comment was marked as abuse.

Sign in to view

sandewt mentioned this pull request Apr 23, 2021

[4.0] Blog-View: Vote-Stars need padding #33164

Closed

rjharishabh deleted the pagination branch April 27, 2021 09:39

[4.0] Pagination set to bottom after voting #32914

[4.0] Pagination set to bottom after voting #32914

Conversation

rjharishabh commented Mar 28, 2021 • edited

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

rjharishabh commented Mar 29, 2021

This comment was marked as abuse.

rjharishabh commented Mar 29, 2021

ghost commented Mar 29, 2021

rjharishabh commented Mar 29, 2021

This comment was marked as abuse.

rjharishabh commented Mar 29, 2021

ceford commented Mar 29, 2021

rjharishabh commented Mar 29, 2021 • edited

Quy commented Mar 29, 2021

Quy commented Mar 29, 2021

rjharishabh commented Mar 29, 2021

rjharishabh commented Mar 31, 2021

infograf768 commented Apr 1, 2021

Before patch

After patch

This comment was marked as abuse.

joomdonation commented Apr 1, 2021

This comment was marked as abuse.

joomdonation commented Apr 1, 2021

rjharishabh commented Apr 1, 2021

infograf768 commented Apr 1, 2021

This comment was marked as abuse.

rjharishabh commented Apr 14, 2021 • edited

ghost commented Apr 16, 2021 • edited by ghost

infograf768 commented Apr 16, 2021

ghost commented Apr 16, 2021

rjharishabh commented Apr 16, 2021

ghost commented Apr 16, 2021

sandewt commented Apr 16, 2021

rjharishabh commented Apr 16, 2021

sandewt commented Apr 16, 2021

rjharishabh commented Apr 16, 2021

drmenzelit commented Apr 16, 2021

brianteeman commented Apr 16, 2021

This comment was marked as abuse.

ghost commented Apr 16, 2021

drmenzelit commented Apr 16, 2021

rjharishabh commented Apr 16, 2021

This comment was marked as abuse.

sandewt commented Apr 17, 2021

sandewt commented Apr 17, 2021

rjharishabh commented Apr 18, 2021 • edited

sandewt commented Apr 18, 2021 • edited

sandewt commented Apr 23, 2021

rjharishabh commented Mar 28, 2021 •

edited

rjharishabh commented Mar 29, 2021 •

edited

rjharishabh commented Apr 14, 2021 •

edited

ghost commented Apr 16, 2021 •

edited by ghost

rjharishabh commented Apr 18, 2021 •

edited

sandewt commented Apr 18, 2021 •

edited