-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#33468] Fixes typo in getter and setter of form fields. #3306
Conversation
case 'inputmode': | ||
$this->name = (string) $value; | ||
$this->$name = (string) $value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you should make this inputmode - as you have for the other 1 instance cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not one instance case. 'dirname' is getting assigned through it. But now I am thinking to change it little bit.
I don't quite see what this PR fixes, as there are no issues with the code. |
@vdespa Following are the lines in which either
https://github.com/joomla/joomla-cms/pull/3306/files#diff-037720088ad5e312e2824e27f2cd5550L101 In this inputmode gets a string value instead of boolean. Other changes are because there is only one property which is present in overridden set & get. So I thought to not to use |
The only issue was in JFormFieldTextarea, which already has a PR. IMHO you are not actually fixing anything, nor are you breaking anything. |
The issue Frederic noticed is same as with |
closed as per the comment on the tracker |
@Achal-Aggarwal the password and file field bugs fixed here still exist. would you mind doing a new pr merging in master to fix please? (also as you have a unit test there would be awesome to add that in!) |
@wilsonge test PR 4100. |
Fixes http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33468&start=0 and similar issues in other field.