Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Remove more deprecated code slated for removal in Joomla 4 #34077

Closed
wants to merge 3 commits into from
Closed

[4] Remove more deprecated code slated for removal in Joomla 4 #34077

wants to merge 3 commits into from

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented May 21, 2021

Code review

Like the code said "As of 3.7.0, passing a null value for the first argument of %1$s() is deprecated and will not be supported in 4.0."

This PR cleans up and enforces this deprecation and fixes the docblocks

$jsSafe is slated as a bool, but the code has code to use it as an array, but its never used as an array by Joomla core so I have not type hinted it just yet, to allow 3PD calling it

Now if you call Text::script(); you will correctly get

Too few arguments to function Joomla\CMS\Language\Text::script(), 0 passed

Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
@RickR2H
Copy link
Member

RickR2H commented Jun 24, 2021

Hey @PhilETaylor How can we test this? I know writing testing instructions isn't fun, but it will insure not so skilled people can also test and PR's get committed faster.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.

@PhilETaylor

This comment was marked as abuse.

@RickR2H
Copy link
Member

RickR2H commented Jan 16, 2022

I have tested this item ✅ successfully on 416d847


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jan 26, 2022

I have tested this item ✅ successfully on 416d847


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.

@Quy Quy removed the PR-4.0-dev label Jan 26, 2022
@Quy
Copy link
Contributor

Quy commented Jan 26, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 26, 2022
@Quy Quy added the PR-4.0-dev label Jan 26, 2022
@Quy Quy changed the base branch from 4.0-dev to 4.1-dev January 27, 2022 20:08
@brianteeman
Copy link
Contributor

Could you please resolve the conflicts

@bembelimen bembelimen added this to the Joomla 5.0 milestone Feb 21, 2022
@Quy Quy removed the PR-4.1-dev label Mar 4, 2022
@PhilETaylor

This comment was marked as abuse.

@PhilETaylor PhilETaylor closed this Mar 7, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2022
@laoneo laoneo removed this from the Joomla! 5.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants