-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4] Remove more deprecated code slated for removal in Joomla 4 #34077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Quy
reviewed
Jun 10, 2021
Hey @PhilETaylor How can we test this? I know writing testing instructions isn't fun, but it will insure not so skilled people can also test and PR's get committed faster. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077. |
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on 416d847 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077. |
1 similar comment
I have tested this item ✅ successfully on 416d847 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077. |
Could you please resolve the conflicts |
This comment was marked as abuse.
This comment was marked as abuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review
Like the code said "As of 3.7.0, passing a null value for the first argument of %1$s() is deprecated and will not be supported in 4.0."
This PR cleans up and enforces this deprecation and fixes the docblocks
$jsSafe
is slated as a bool, but the code has code to use it as an array, but its never used as an array by Joomla core so I have not type hinted it just yet, to allow 3PD calling itNow if you call
Text::script();
you will correctly get